Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 21 Jun 2016 16:54:57 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12976182.1465242266000.12476.1466528097934@Atlassian.JIRA>
In-Reply-To: <JIRA.12976182.1465242266000@Atlassian.JIRA>
References: <JIRA.12976182.1465242266000@Atlassian.JIRA> <JIRA.12976182.1465242266949@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9407) vm_network_map table doesnt
 get cleaned up properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 21 Jun 2016 16:55:00 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342165#comment-15342165 ] 

ASF GitHub Bot commented on CLOUDSTACK-9407:
--------------------------------------------

Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1594#discussion_r67907402
  
    --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
    @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm, final boolean cleanUpEvenIfUnabl
             }
     
             try {
    -            _networkMgr.release(profile, cleanUpEvenIfUnableToStop);
    -            s_logger.debug("Successfully released network resources for the vm " + vm);
    +            s_logger.debug("Not releasing network resources until expunge command is sent");
    --- End diff --
    
    I decided to remove try-block as it only logged info, and include it on method's javadoc, as I don't think it could be worth logging. Do you agree?


> vm_network_map table doesnt get cleaned up properly
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-9407
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9407
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>             Fix For: 4.9.0
>
>
> h3. Introduction
> It was found out that in production environments {{vm_network_map}} table entries were slowly growing. It was investigated how this entries were cleaned up.
> h3. Behaviour
> On vm creation, vm mappings are inserted on {{vm_network_map}}.
> On vm stop, mappings are deleted from {{vm_network_map}} for vm, as a result of the release of its nics.
> h3. Problem
> If created vm is stopped from hypervisor side (at least on vSphere in which we tested it), when CloudStack realizes vm is stopped it doesn't clean up {{vm_network_table}}, and, as cleanup is made during vm stop, when vm is eventually destroyed and expunged it won't clean up their entries in that table.
> h3. Proposed solution
> We propose to move {{vm_network_map}} table cleanup to expunge command instead of stop command.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)