Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E638200B32 for ; Wed, 8 Jun 2016 09:20:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0D61F160A29; Wed, 8 Jun 2016 07:20:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30FF5160A2E for ; Wed, 8 Jun 2016 09:20:22 +0200 (CEST) Received: (qmail 71973 invoked by uid 500); 8 Jun 2016 07:20:21 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 71807 invoked by uid 500); 8 Jun 2016 07:20:21 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 71804 invoked by uid 99); 8 Jun 2016 07:20:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2016 07:20:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 07D302C1F60 for ; Wed, 8 Jun 2016 07:20:21 +0000 (UTC) Date: Wed, 8 Jun 2016 07:20:21 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9399) NullPointerException when deleting Host MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Jun 2016 07:20:23 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320170#comment-15320170 ] ASF GitHub Bot commented on CLOUDSTACK-9399: -------------------------------------------- Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1585 The Java code fix seems good to me, never hurts to check for NULL, right? > NullPointerException when deleting Host > --------------------------------------- > > Key: CLOUDSTACK-9399 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9399 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server, Network Controller > Reporter: Mani Prashanth Varma Manthena > Assignee: Nick Livens > Fix For: 4.9.0 > > > Nuage VSP : NullPointerException while deleting Nuage Vsp Device > Here is the exception: > {noformat} > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116 ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST to BaremetalDhcpManagerImpl > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116 ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST to NetworkUsageManagerImpl > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116 ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST to Ovs > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Unexpected exception while executing com.cloud.api.commands.DeleteNuageVspDeviceCmd > May 31 11:48:19 csc-1 management-server.log: java.lang.NullPointerException > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.resource.ResourceManagerImpl.doDeleteHost(ResourceManagerImpl.java:850) > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.resource.ResourceManagerImpl.deleteHost(ResourceManagerImpl.java:946) > May 31 11:48:19 csc-1 management-server.log: #011at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > May 31 11:48:19 csc-1 management-server.log: #011at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > May 31 11:48:19 csc-1 management-server.log: #011at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > May 31 11:48:19 csc-1 management-server.log: #011at java.lang.reflect.Method.invoke(Method.java:606) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > May 31 11:48:19 csc-1 management-server.log: #011at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > May 31 11:48:19 csc-1 management-server.log: #011at com.sun.proxy.$Proxy161.deleteHost(Unknown Source) > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.network.manager.NuageVspManagerImpl.deleteNuageVspDevice(NuageVspManagerImpl.java:533) > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.api.commands.DeleteNuageVspDeviceCmd.execute(DeleteNuageVspDeviceCmd.java:75) > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > May 31 11:48:19 csc-1 management-server.log: #011at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:554) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) > May 31 11:48:19 csc-1 management-server.log: #011at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:502) > May 31 11:48:19 csc-1 management-server.log: #011at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > May 31 11:48:19 csc-1 management-server.log: #011at java.util.concurrent.FutureTask.run(FutureTask.java:262) > May 31 11:48:19 csc-1 management-server.log: #011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > May 31 11:48:19 csc-1 management-server.log: #011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > May 31 11:48:19 csc-1 management-server.log: #011at java.lang.Thread.run(Thread.java:745) > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,496 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Complete async job-116, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":530} > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Publish async job-116 complete on message bus > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Wake up jobs related to job-116 > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Update db status for job-116 > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,500 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Wake up jobs joined with job-116 and disjoin all subjobs created from job- 116 > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,505 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Done executing com.cloud.api.commands.DeleteNuageVspDeviceCmd for job-116 > May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,505 INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-76:ctx-80e26bc5 job-116) (logid:d5f86638) Remove job-116 from job monitoring > May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,119 DEBUG [c.c.a.ApiServlet] (catalina-exec-19:ctx-43e00b8a) (logid:2c035630) ===START=== 0:0:0:0:0:0:0:1 -- GET signatureversion=3&apiKey=StjgrAiYEguhhZwogkx4SggkPhImhdxgSrDbfUZhLjL4As6bm4Xec8GC7WKFWuZXJmTAIl9zx_Qeh767T_yfpQ&expires=2016-05-31T18%3A58%3A21%2B0000&jobid=d5f86638-e270-4718-83fa-ff9a19ecf111&command=queryAsyncJobResult&signature=hhCmPvlhtDlFkR2XLvzm2OCs5%2BI%3D&response=json > May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,122 DEBUG [o.s.b.f.a.InjectionMetadata] (catalina-exec-19:ctx-43e00b8a ctx-037d0e9e ctx-b3bda2da) (logid:2c035630) Processing injected element of bean 'org.apache.cloudstack.api.command.user.job.QueryAsyncJobResultCmd': AutowiredFieldElement for public com.cloud.configuration.ConfigurationService org.apache.cloudstack.api.BaseCmd._configService > May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,123 DEBUG [o.s.b.f.s.DefaultListableBeanFactory] (catalina-exec-19:ctx-43e00b8a ctx-037d0e9e ctx-b3bda2da) (logid:2c035630) Returning cached instance of singleton bean 'configurationManagerImpl' > {noformat} > PR contents: > 1) Fix for this bug > 2) Marvin test coverage for Nuage VSP device CRUD operations including verifications for this bug fix. > PEP8 & PyFlakes compliance of the added Marvin code: > CloudStack$ > CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py > CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py > CloudStack$ > Marvin Test Run: > CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg /test/integration/plugins/nuagevsp/test_nuage_vsp.py > Marvin Test Results: > Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === > ok > Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS === > ok > Ran 2 tests in 447.773s > OK -- This message was sent by Atlassian JIRA (v6.3.4#6332)