cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9389) [Automation ]modifying integration/smoke/test_routers_network_ops.py
Date Thu, 09 Jun 2016 12:06:20 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322401#comment-15322401
] 

ASF GitHub Bot commented on CLOUDSTACK-9389:
--------------------------------------------

Github user swill commented on the issue:

    https://github.com/apache/cloudstack/pull/1563
  
    This assumes that people know how to work with the test data and that they understand
that "this random template needs X format and this other one will need Y format".  This is
too much to ask without guidance, especially as we try to improve the automatability of the
testing.  
    
    The regex idea is not a perfect solution, but would allow for us to handle more template
types with a single entry.  Ideally we would be able to specify the expected values for this
type of thing in an OS specific way so the tested (and verified) values for each OS can live
in the test data. It would probably need a default that is used if the current OS does not
have a match. 
    
    My main problem with this is that it will, by default,  break this test for everyone using
bubble to automate their testing. Maybe we leave the old default test value in place, and
people who are testing with other OSs can now override manually. 
    
    What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity
for us to review the way we handle OS specific test data. 


> [Automation ]modifying integration/smoke/test_routers_network_ops.py
> --------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9389
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9389
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>            Reporter: prashant kumar mishra
>            Assignee: prashant kumar mishra
>
> Some test cases were failing due to invalid check_string , proposing following modifications
 
> 1-Moving check_string to test_data.py  
> 2-Since ping cmd reply is OS dependent ,for  default templates os type  CentOS changing
check_string  from "3 packets received" to  "3 received" 
> [root@BPKxDmS ~]# ping -c 3 8.8.8.8
> PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.
> 64 bytes from 8.8.8.8: icmp_seq=1 ttl=52 time=16.9 ms
> 64 bytes from 8.8.8.8: icmp_seq=2 ttl=52 time=16.7 ms
> 64 bytes from 8.8.8.8: icmp_seq=3 ttl=52 time=17.0 ms
> --- 8.8.8.8 ping statistics ---
> 3 packets transmitted, 3 received, 0% packet loss, time 2020ms
> rtt min/avg/max/mdev = 16.720/16.896/17.015/0.196 ms



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message