Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1391200AC0 for ; Tue, 24 May 2016 11:49:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AFDF5160A27; Tue, 24 May 2016 09:49:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 02664160A11 for ; Tue, 24 May 2016 11:49:28 +0200 (CEST) Received: (qmail 5938 invoked by uid 500); 24 May 2016 09:49:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 5886 invoked by uid 500); 24 May 2016 09:49:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 5838 invoked by uid 99); 24 May 2016 09:49:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2016 09:49:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 38B962C1F72 for ; Tue, 24 May 2016 09:49:13 +0000 (UTC) Date: Tue, 24 May 2016 09:49:13 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9377) Metrics data incorrectly calculated in zone/cluster metrics view MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 May 2016 09:49:29 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297983#comment-15297983 ] ASF subversion and git services commented on CLOUDSTACK-9377: ------------------------------------------------------------- Commit a38b17fff2da18dc480fed684f84e1e6f03a910b in cloudstack's branch refs/heads/4.9-bountycastle-daan from [~williamstevens@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a38b17f ] Merge pull request #1540 from shapeblue/metrics-pagesize-fix CLOUDSTACK-9377: Fix metrics pagesize issueFixes listing of clusters and host to list all clusters/hosts by passing pagesize=-1. /cc @koushik-das @swill @DaanHoogland -- fixes the issue raised on dev@ ML by Rashmi * pr/1540: CLOUDSTACK-9377: Fix metrics pagesize issue Signed-off-by: Will Stevens > Metrics data incorrectly calculated in zone/cluster metrics view > ---------------------------------------------------------------- > > Key: CLOUDSTACK-9377 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9377 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: UI > Affects Versions: 4.7.0 > Reporter: Rashmi Dixit > Assignee: Rohit Yadav > Labels: UI, metrics > Fix For: 4.9.0 > > > In the zone metrics view, listClusters and listHosts APIs are being used to compute average used and allocated data for metrics calculations. > Issue: > 1. All APIs have a default pagesize. Count of results are always equal to the default pagesize if not explicitly passed. The UI is not passing anything related to pagesize to these APIs > 2. Example to explain issue > 600 hosts in a cluster. Default Page size = 500. > There is only one call to fetch clusters. This will fetch a maximum of 500 records. If there are more, then these aren't fetched. > For each cluster, listHosts is called to fetch hosts. Since page size is 500 only 500 results are returned. > Computation for 500 hosts is done but for calculating average this value is divided by 600. This is incorrect. > UI should fetch all hosts in one go and correctly calculate metrics. However, this will result in performance degradation as number of hosts/clusters increase. > Ideally a new API needs to be introduced for this metrics calculation. > Same issue is present in the cluster metrics view. -- This message was sent by Atlassian JIRA (v6.3.4#6332)