Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06D86200AE2 for ; Mon, 2 May 2016 22:21:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03E721609B1; Mon, 2 May 2016 22:21:15 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4D1711609B0 for ; Mon, 2 May 2016 22:21:14 +0200 (CEST) Received: (qmail 97801 invoked by uid 500); 2 May 2016 20:21:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 97777 invoked by uid 500); 2 May 2016 20:21:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 97772 invoked by uid 99); 2 May 2016 20:21:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 20:21:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3417D2C1F6B for ; Mon, 2 May 2016 20:21:13 +0000 (UTC) Date: Mon, 2 May 2016 20:21:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9368) Fix for Support configurable NFS version for Secondary Storage mounts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 May 2016 20:21:15 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267423#comment-15267423 ] ASF GitHub Bot commented on CLOUDSTACK-9368: -------------------------------------------- Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216351223 Just an update, I forgot to ask, can you squash the commits? I think this one it is better to have all of the changes into a single commit. > Fix for Support configurable NFS version for Secondary Storage mounts > --------------------------------------------------------------------- > > Key: CLOUDSTACK-9368 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9368 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: VMware > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Fix For: 4.9.0 > > > This issue address a problem introduced in [CLOUDSTACK-9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] in which NFS version couldn't be changed after hosts resources were configured on startup (for hosts using `VmwareResource`), and as host parameters didn't include `nfs.version` key, it was set `null`. > h4. Proposed solution > In this proposed solution `nfsVersion` would be passed in `NfsTO` through `CopyCommand` to `VmwareResource`, who will check if NFS version is still configured or not. If not, it will use the one sent in the command and will set it to its storage processor and storage handler. After those setups, it will proceed executing command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)