Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Mon, 2 May 2016 15:26:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12962221.1461586030000.86280.1462202772871@Atlassian.JIRA>
In-Reply-To: <JIRA.12962221.1461586030000@Atlassian.JIRA>
References: <JIRA.12962221.1461586030000@Atlassian.JIRA> <JIRA.12962221.1461586030551@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9368) Fix for Support configurable
 NFS version for Secondary Storage mounts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 02 May 2016 15:26:14 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266780#comment-15266780 ] 

ASF GitHub Bot commented on CLOUDSTACK-9368:
--------------------------------------------

Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1518#discussion_r61754039
  
    --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java ---
    @@ -0,0 +1,44 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +package com.cloud.agent.api.storage;
    +
    +import com.cloud.agent.api.Command;
    +
    +public abstract class StorageNfsVersionCommand extends Command {
    +
    +    protected StorageNfsVersionCommand(){
    --- End diff --
    
    Actually, I kept it for the hierarchy. Classes extending <code>StorageNfsVersionCommand</code> will not compile if I remove it, in their constructors the error will be:
    ````
    Implicit super constructor StorageNfsVersionCommand() is undefined. Must explicitly invoke another constructor
    ````
    Do you agree about keeping it?


> Fix for Support configurable NFS version for Secondary Storage mounts
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9368
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9368
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>             Fix For: 4.9.0
>
>
> This issue address a problem introduced in [CLOUDSTACK-9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] in which NFS version couldn't be changed after hosts resources were configured on startup (for hosts using `VmwareResource`), and as host parameters didn't include `nfs.version` key, it was set `null`.
> h4. Proposed solution
> In this proposed solution `nfsVersion` would be passed in `NfsTO` through `CopyCommand` to `VmwareResource`, who will check if NFS version is still configured or not. If not, it will use the one sent in the command and will set it to its storage processor and storage handler. After those setups, it will proceed executing command.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)