Return-Path: <issues-return-71471-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 79808200AC0
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 24 May 2016 11:32:14 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 78175160A27; Tue, 24 May 2016 09:32:14 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C3136160A11
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 24 May 2016 11:32:13 +0200 (CEST)
Received: (qmail 66832 invoked by uid 500); 24 May 2016 09:32:13 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 66823 invoked by uid 500); 24 May 2016 09:32:12 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 66820 invoked by uid 99); 24 May 2016 09:32:12 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2016 09:32:12 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id CA0E62C1F56
	for <cloudstack-issues@incubator.apache.org>; Tue, 24 May 2016 09:32:12 +0000 (UTC)
Date: Tue, 24 May 2016 09:32:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12941026.1456143770000.275207.1464082332825@Atlassian.JIRA>
In-Reply-To: <JIRA.12941026.1456143770000@Atlassian.JIRA>
References: <JIRA.12941026.1456143770000@Atlassian.JIRA> <JIRA.12941026.1456143770994@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9294) Nuage Plugin : VR doesn't get
 removed from the VSD when destroying a VPC
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 24 May 2016 09:32:14 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297963#comment-15297963 ] 

ASF GitHub Bot commented on CLOUDSTACK-9294:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java ---
    @@ -19,173 +19,43 @@
     
     package com.cloud.agent.api.element;
     
    -import com.cloud.agent.api.CmdBuilder;
     import com.cloud.agent.api.Command;
    +import net.nuage.vsp.acs.client.api.model.VspAclRule;
    +import net.nuage.vsp.acs.client.api.model.VspNetwork;
     
     import java.util.List;
    -import java.util.Map;
     
     public class ApplyAclRuleVspCommand extends Command {
     
    -    private final boolean _networkAcl;
    -    private final String _networkUuid;
    -    private final String _networkDomainUuid;
    -    private final String _vpcOrSubnetUuid;
    -    private final String _networkName;
    -    private final boolean _isL2Network;
    -    private final List<Map<String, Object>> _aclRules;
    -    private final long _networkId;
    -    private final boolean _egressDefaultPolicy;
    -    private final Boolean _acsIngressAcl;
    +    private final VspAclRule.ACLType _aclType;
    +    private final VspNetwork _network;
    +    private final List<VspAclRule> _aclRules;
    --- End diff --
    
    I am assuming that VspNetwork, VspAclRule etc. are all serialisable.


> Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9294
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9294
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Third-Party Bugs
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>             Fix For: 4.9.0
>
>
> When destroying a VPC, the VR doesn't get removed from the VSD



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)