Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 20 May 2016 17:35:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12941026.1456143770000.250845.1463765712899@Atlassian.JIRA>
In-Reply-To: <JIRA.12941026.1456143770000@Atlassian.JIRA>
References: <JIRA.12941026.1456143770000@Atlassian.JIRA> <JIRA.12941026.1456143770994@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9294) Nuage Plugin : VR doesn't get
 removed from the VSD when destroying a VPC
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 20 May 2016 17:35:14 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293805#comment-15293805 ] 

ASF GitHub Bot commented on CLOUDSTACK-9294:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64078451
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java ---
    @@ -270,15 +258,15 @@ public PingCommand getCurrentStatus(long id) {
                 _shouldAudit = true;
                 return null;
             }
    -        if (_cmsUserInfo == null || _cmsUserInfo.length < 2) {
    +        if (_cmsUserLogin == null || _cmsUserLogin.isEmpty() || _cmsUserPassword == null || _cmsUserPassword.isEmpty()) {
    --- End diff --
    
    @nlivens you can use StringUtils.isEmpty(CharString cs) [https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html] in order to check if a String is empty or null.


> Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9294
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9294
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Third-Party Bugs
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>             Fix For: 4.9.0
>
>
> When destroying a VPC, the VR doesn't get removed from the VSD


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)