Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9D01A2009F4 for ; Thu, 26 May 2016 16:48:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9B6E1160A18; Thu, 26 May 2016 14:48:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DFF8E160A17 for ; Thu, 26 May 2016 16:48:18 +0200 (CEST) Received: (qmail 75463 invoked by uid 500); 26 May 2016 14:48:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 75451 invoked by uid 500); 26 May 2016 14:48:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 75445 invoked by uid 99); 26 May 2016 14:48:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 May 2016 14:48:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D85E62C1F5D for ; Thu, 26 May 2016 14:48:12 +0000 (UTC) Date: Thu, 26 May 2016 14:48:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9238) URL fields in database are to small. Cause malformed URLs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 May 2016 14:48:19 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302174#comment-15302174 ] ASF GitHub Bot commented on CLOUDSTACK-9238: -------------------------------------------- Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221893016 Maybe you meant to change on this table: `` alter table `vm_template` modify column `url` varchar(2048) DEFAULT NULL COMMENT 'the url where the template exists externally'; `` > URL fields in database are to small. Cause malformed URLs > --------------------------------------------------------- > > Key: CLOUDSTACK-9238 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.6.0, 4.7.0, 4.8.0 > Reporter: Wido den Hollander > Assignee: Wido den Hollander > Labels: s3, template, templates, url, urls > Fix For: 4.8.0 > > > In for example the 'volume_store_ref' table the 'download_url' field is a VARCHAR(255). > This is to short for URLs. Same goes for the 'object_datastore_ref' table and the 'url' field. > With pre-signed S3 URLs this will cause issues. > The fix would be to change the database fields to a VARCHAR(2048). No code-change is required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)