Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 3 May 2016 17:01:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12924704.1451403638000.99695.1462294872880@Atlassian.JIRA>
In-Reply-To: <JIRA.12924704.1451403638000@Atlassian.JIRA>
References: <JIRA.12924704.1451403638000@Atlassian.JIRA> <JIRA.12924704.1451403638901@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9203) [API] extend
 updateVirtualMachine to support updating security groups
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 03 May 2016 17:01:14 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9203?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15269079#comment-15269079 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9203:
--------------------------------------------

GitHub user DaanHoogland reopened a pull request:

    https://github.com/apache/cloudstack/pull/1297

    CLOUDSTACK-9203 Implement security group move on updateVM API call

      cherry-picked from a exoscale internal fix
   =20
    Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
    =09server/src/com/cloud/vm/UserVmManager.java
    =09server/src/com/cloud/vm/UserVmManagerImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1297
   =20
----
commit 8c633f27622b09aca4f49062baeca83523071c06
Author: Daan Hoogland <daan@onecht.net>
Date:   2016-04-11T18:22:34Z

    CLOUDSTACK-9203 Implement security group move on updateVM API call
   =20
      cherry-picked from a exoscale internal fix
   =20
    Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
    =09server/src/com/cloud/vm/UserVmManager.java
    =09server/src/com/cloud/vm/UserVmManagerImpl.java

commit 6e7260ed246f955429a3a1c0e93576c9d4864fca
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-12-30T12:13:38Z

    CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as wel=
l
   =20
     Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit 4506fa93f00c18800d31a2d00e5698c80622936b
Author: Loic Lambiel <lll@exoscale.ch>
Date:   2015-05-15T13:15:26Z

    CLOUDSTACK-9203 Prevent security group update while instance is running
   =20
          cherry-picked from a exoscale internal fix
   =20
     Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

commit 7bce4badbe29724e575883ef9485312603dfc46c
Author: Wei Zhou <w.zhou@tech.leaseweb.com>
Date:   2016-01-12T09:56:07Z

    CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit 3d859c90effd71aab99f97ae65e2cad30960ca4b
Author: Wei Zhou <w.zhou@tech.leaseweb.com>
Date:   2016-01-22T11:45:13Z

    CLOUDSTACK-9203: fix issue when update vm in isolated networks

commit b7d58e6451a2f2234f05d6899a62a0e5da7e87e2
Author: Daan Hoogland <daan@onecht.net>
Date:   2016-04-11T18:22:34Z

    CLOUDSTACK-9203 Implement security group move on updateVM API call
   =20
      cherry-picked from a exoscale internal fix
   =20
    Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
    =09server/src/com/cloud/vm/UserVmManager.java
    =09server/src/com/cloud/vm/UserVmManagerImpl.java

commit 82a8d2dde76289dcd7a17ebda6fec8af07f8df73
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-12-30T12:13:38Z

    CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as wel=
l
   =20
     Conflicts:
    =09api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

----


> [API] extend updateVirtualMachine to support updating security groups
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9203
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-920=
3
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: API
>            Reporter: Ren=C3=A9 Moser
>            Assignee: Daan Hoogland
>            Priority: Minor
>             Fix For: Future
>
>
> There is currently no way to change security groups on exisitng VMs.
> {{updateVirtualMachine}} should be extended in a similar way as {{deployV=
irtualMachine}} which should allow passing a list of IDs or names to update=
 the security groups as passed:
> {{securitygroupids}} parameter
> comma separated list of security groups id that going to be applied to th=
e virtual machine. Should be passed only when vm is created from a zone wit=
h Basic Network support. Mutually exclusive with securitygroupnames paramet=
er, default: false
> {{securitygroupnames}} parameter
> comma separated list of security groups names that going to be applied to=
 the virtual machine. Should be passed only when vm is created from a zone =
with Basic Network support. Mutually exclusive with securitygroupids parame=
ter. default: false
> Exoscale did already some work in their branch which we are [allowed|http=
s://twitter.com/resmo79/status/681428989018267648] to use, see [https://git=
hub.com/exoscale/cloudstack/pull/6/]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)