Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 4 May 2016 14:27:13 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12779788.1425561661000.108413.1462372033376@Atlassian.JIRA>
In-Reply-To: <JIRA.12779788.1425561661000@Atlassian.JIRA>
References: <JIRA.12779788.1425561661000@Atlassian.JIRA> <JIRA.12779788.1425561661534@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with
 RBD
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 04 May 2016 14:27:15 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15270705#comment-15270705 ]=20

ASF subversion and git services commented on CLOUDSTACK-8302:
-------------------------------------------------------------

Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch refs=
/heads/master from [~williamstevens@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3Dc9319e2 ]

Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302

CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if =
primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

* pr/1230:
  CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing impl=
emented on RBD. 1. On management side: when created new shanpshot we checki=
ng if our primary storage is RBD, then do not remove record from cloud.snap=
shot_store_ref with link to Ceph image via 'install_path' field. 2. On mana=
gement side: when removing snapshot, also send command to agent 'DeleteComm=
and'. 3. On agent side: method implemented 'public Answer deleteSnapshot(fi=
nal DeleteCommand cmd)'

Signed-off-by: Will Stevens <williamstevens@gmail.com>


> Cleanup snapshot on KVM with RBD
> --------------------------------
>
>                 Key: CLOUDSTACK-8302
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-830=
2
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: KVM, Snapshot, Storage Controller
>    Affects Versions: 4.4.0, 4.4.1, 4.4.2
>         Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80=
.8
>            Reporter: Star Guo
>            Assignee: Wido den Hollander
>            Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80=
.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When =
delete a snapshot the UI show OK, but the snapshot of the volume in the RBD=
 pool is still exist.
> And I find the code in com/cloud/hypervisor/kvm/storage/KVMStorageProcess=
or.java:=20
> =E2=80=A6
>     @Override
>     public Answer deleteSnapshot(DeleteCommand cmd) {
>         return new Answer(cmd);
>     }
> =E2=80=A6
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
>     @Override
>     public Answer createTemplateFromSnapshot(CopyCommand cmd) {
>         return null;  //To change body of implemented methods use File | =
Settings | File Templates.
>     }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch=
 but not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)