cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9368) Fix for Support configurable NFS version for Secondary Storage mounts
Date Tue, 17 May 2016 09:52:12 GMT


ASF GitHub Bot commented on CLOUDSTACK-9368:

Github user koushik-das commented on a diff in the pull request:
    --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/
    @@ -79,6 +80,25 @@
         VMTemplateZoneDao _vmTemplateZoneDao;
         AlertManager _alertMgr;
    +    @Inject
    +    ImageStoreDetailsDao _imageStoreDetailsDao;
    +    private static final String NFS_VERSION_DETAILS_KEY = "nfs.version";
    --- End diff --
    @nvazquez One way would be create an intermediate class for NFS based stores and derive
CloudStackImageStoreDriverImpl and SimulatorImageStoreDriverImpl from that.

> Fix for Support configurable NFS version for Secondary Storage mounts
> ---------------------------------------------------------------------
>                 Key: CLOUDSTACK-9368
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>             Fix For: 4.9.0
> This issue address a problem introduced in [CLOUDSTACK-9252|]
in which NFS version couldn't be changed after hosts resources were configured on startup
(for hosts using `VmwareResource`), and as host parameters didn't include `nfs.version` key,
it was set `null`.
> h4. Proposed solution
> In this proposed solution `nfsVersion` would be passed in `NfsTO` through `CopyCommand`
to `VmwareResource`, who will check if NFS version is still configured or not. If not, it
will use the one sent in the command and will set it to its storage processor and storage
handler. After those setups, it will proceed executing command.

This message was sent by Atlassian JIRA

View raw message