cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9294) Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
Date Fri, 20 May 2016 17:47:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293830#comment-15293830
] 

ASF GitHub Bot commented on CLOUDSTACK-9294:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64080090
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
    @@ -0,0 +1,370 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.util;
    +
    +import com.cloud.dc.VlanVO;
    +import com.cloud.dc.dao.VlanDao;
    +import com.cloud.domain.Domain;
    +import com.cloud.domain.DomainVO;
    +import com.cloud.domain.dao.DomainDao;
    +import com.cloud.exception.InsufficientVirtualNetworkCapacityException;
    +import com.cloud.network.Network;
    +import com.cloud.network.NetworkModel;
    +import com.cloud.network.dao.IPAddressDao;
    +import com.cloud.network.dao.IPAddressVO;
    +import com.cloud.network.dao.NetworkDetailsDao;
    +import com.cloud.network.rules.FirewallRule;
    +import com.cloud.network.vpc.NetworkACLItem;
    +import com.cloud.network.vpc.VpcVO;
    +import com.cloud.network.vpc.dao.VpcDao;
    +import com.cloud.offerings.NetworkOfferingVO;
    +import com.cloud.offerings.dao.NetworkOfferingDao;
    +import com.cloud.offerings.dao.NetworkOfferingServiceMapDao;
    +import com.cloud.user.AccountVO;
    +import com.cloud.user.dao.AccountDao;
    +import com.cloud.utils.exception.CloudRuntimeException;
    +import com.cloud.utils.net.NetUtils;
    +import com.cloud.vm.NicProfile;
    +import com.cloud.vm.NicVO;
    +import com.cloud.vm.VirtualMachine;
    +import com.google.common.collect.Iterables;
    +import com.google.common.collect.Lists;
    +import net.nuage.vsp.acs.client.api.model.VspAclRule;
    +import net.nuage.vsp.acs.client.api.model.VspDomain;
    +import net.nuage.vsp.acs.client.api.model.VspNetwork;
    +import net.nuage.vsp.acs.client.api.model.VspNic;
    +import net.nuage.vsp.acs.client.api.model.VspStaticNat;
    +import net.nuage.vsp.acs.client.api.model.VspVm;
    +import net.nuage.vsp.acs.client.common.model.Pair;
    +import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
    +import org.apache.commons.lang.StringUtils;
    +import org.apache.log4j.Logger;
    +
    +import javax.inject.Inject;
    +import java.util.HashSet;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Set;
    +import java.util.TreeSet;
    +
    +public class NuageVspEntityBuilder {
    +    private static final Logger s_logger = Logger.getLogger(NuageVspEntityBuilder.class);
    +
    +    @Inject
    +    VpcDao _vpcDao;
    +    @Inject
    +    DomainDao _domainDao;
    +    @Inject
    +    AccountDao _accountDao;
    +    @Inject
    +    NetworkOfferingDao _networkOfferingDao;
    +    @Inject
    +    NetworkOfferingServiceMapDao _networkOfferingServiceMapDao;
    +    @Inject
    +    NetworkModel _networkModel;
    +    @Inject
    +    VlanDao _vlanDao;
    +    @Inject
    +    ConfigurationDao _configurationDao;
    +    @Inject
    +    IPAddressDao _ipAddressDao;
    +    @Inject
    +    NetworkDetailsDao _networkDetailsDao;
    --- End diff --
    
    @nlivens shouldn't those variables be private? Thanks.


> Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9294
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9294
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Third-Party Bugs
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>             Fix For: 4.9.0
>
>
> When destroying a VPC, the VR doesn't get removed from the VSD



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message