cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9238) URL fields in database are to small. Cause malformed URLs
Date Wed, 25 May 2016 10:16:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299805#comment-15299805
] 

ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------

GitHub user wido opened a pull request:

    https://github.com/apache/cloudstack/pull/1562

    CLOUDSTACK-9238: Change template_host_ref.url to varchar(2048)

    In Pull Request #1341 / commit a171bb this was fixed for many other
    URL fields, but this was not corrected and is still a varchar(255)
    
    Change this field to a varchar(2048) to accomodate longer URLs in
    the database.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-9238

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1562
    
----
commit a77a301f715ea64f3c5e0ff8b37923663868f1a6
Author: Wido den Hollander <wido@widodh.nl>
Date:   2016-05-25T10:12:58Z

    CLOUDSTACK-9238: Change template_host_ref.url to varchar(2048)
    
    In Pull Request #1341 / commit a171bb this was fixed for many other
    URL fields, but this was not corrected and is still a varchar(255)
    
    Change this field to a varchar(2048) to accomodate longer URLs in
    the database.

----


> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-9238
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0, 4.7.0, 4.8.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>              Labels: s3, template, templates, url, urls
>             Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and the 'url'
field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No code-change is
required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message