cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9165) unable to use reserved IP range in a network for external VMs
Date Mon, 09 May 2016 14:11:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276402#comment-15276402
] 

ASF GitHub Bot commented on CLOUDSTACK-9165:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1246#discussion_r62503830
  
    --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
    @@ -755,6 +755,16 @@ protected HypervisorType getClusterToStartDomainRouterForOvm(final
long podId) {
             return networks;
         }
     
    +    /**
    +     * Return a string representing network Cidr for the specifeid network
    +     * @param guestNetwork
    +     * @return valid network Cidr for the specified network
    +     */
    +    protected String getValidNetworkCidr(Network guestNetwork){
    --- End diff --
    
    I think you should extract this method to another common class (e.g. NetworkModel) since
this method can be reused over the different classes.


> unable to use reserved IP range in a network for external VMs
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9165
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9165
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: sudharma jain
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message