Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C757019CBB for ; Thu, 21 Apr 2016 20:43:15 +0000 (UTC) Received: (qmail 12032 invoked by uid 500); 21 Apr 2016 20:43:13 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 11739 invoked by uid 500); 21 Apr 2016 20:43:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 11384 invoked by uid 500); 21 Apr 2016 20:43:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 11145 invoked by uid 99); 21 Apr 2016 20:43:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 20:43:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3880E2C1F62 for ; Thu, 21 Apr 2016 20:43:13 +0000 (UTC) Date: Thu, 21 Apr 2016 20:43:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9354) Problem creating template from snapshot via Marvin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9354?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D15252679#comment-15252679 ]=20 ASF GitHub Bot commented on CLOUDSTACK-9354: -------------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1501 > Problem creating template from snapshot via Marvin > -------------------------------------------------- > > Key: CLOUDSTACK-9354 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-935= 4 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: marvin > Affects Versions: 4.9.0 > Environment: N/A > Reporter: Mike Tutkowski > Assignee: Mike Tutkowski > Fix For: 4.9.0 > > > From an e-mail I sent to dev@ on April 14, 2016: > Hi, > I noticed an issue in Marvin the other day and I tracked it to this commi= t: > https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dcommit;h= =3Dbbe0fc4be9527d51820b067a602886003991db4d > The problem is that it assumes the "ispublic" parameter will be provided.= If it is not, then an exception is thrown. > I think we want code more like this: > if "ispublic" in services: > cmd.ispublic =3D services["ispublic"] > I don't think we would want to require the "ispublic" parameter in Marvin= . It's not required in our API: > http://cloudstack.apache.org/api/apidocs-4.8/root_admin/createTemplate.ht= ml=E2=80=8B > Unless someone can think of a reason why this part of the code is the way= it is now, I plan to open a PR to fix this soon. > Thanks, > Mike -- This message was sent by Atlassian JIRA (v6.3.4#6332)