Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ADF5F19504 for ; Fri, 15 Apr 2016 18:02:26 +0000 (UTC) Received: (qmail 81466 invoked by uid 500); 15 Apr 2016 18:02:26 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 81395 invoked by uid 500); 15 Apr 2016 18:02:25 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 81367 invoked by uid 500); 15 Apr 2016 18:02:25 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 81361 invoked by uid 99); 15 Apr 2016 18:02:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 18:02:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 89C292C1F5D for ; Fri, 15 Apr 2016 18:02:25 +0000 (UTC) Date: Fri, 15 Apr 2016 18:02:25 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9351) Add ids parameter to resource listing API calls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243330#comment-15243330 ] ASF GitHub Bot commented on CLOUDSTACK-9351: -------------------------------------------- Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210566503 Hi @rafaelweingartner, yes, I did test them. I provided new parameters in API calls and they retrieved objects as expected. About the implementation, I was aware that listVirtualMachines had this parameter already implemented, so tried replicating the same idea, as it is in QueryManagerImpl in lines 792, 847, 937 > Add ids parameter to resource listing API calls > ----------------------------------------------- > > Key: CLOUDSTACK-9351 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9351 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: API > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Fix For: 4.9.0 > > > h2. General behaviour > A new parameter is added in each method, its type a list of IDs of the entity, it will be mutually exclusive with id. (Similar to {{id}} and {{ids}} parameters in {{listVirtualMachines}} method) > h3. API Methods affected > * +{{listTemplates}}+: new parameter *{{ids}}*, mutually exclusive with {{id}} > * +{{listVolumes}}+: new parameter *{{ids}}*, mutually exclusive with {{id}} > * +{{listSnapshots}}+: new parameter *{{ids}}*, mutually exclusive with {{id}} > * +{{listVMSnapshots}}+: new parameter *{{vmsnapshotids}}*, mutually exclusive with {{vmsnapshotid}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)