Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA364197D9 for ; Thu, 28 Apr 2016 09:30:13 +0000 (UTC) Received: (qmail 41878 invoked by uid 500); 28 Apr 2016 09:30:13 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 41792 invoked by uid 500); 28 Apr 2016 09:30:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 41582 invoked by uid 500); 28 Apr 2016 09:30:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 41532 invoked by uid 99); 28 Apr 2016 09:30:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 09:30:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 23DC12C1F54 for ; Thu, 28 Apr 2016 09:30:13 +0000 (UTC) Date: Thu, 28 Apr 2016 09:30:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8950) Hypervisor Parameter check is not performed for registerTemplate and getUploadParamsForTemplate API's. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261854#comment-15261854 ] ASF GitHub Bot commented on CLOUDSTACK-8950: -------------------------------------------- Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-215366187 @karuturi Any updates on this? > Hypervisor Parameter check is not performed for registerTemplate and getUploadParamsForTemplate API's. > ------------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-8950 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8950 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Rajani Karuturi > Assignee: Rajani Karuturi > Fix For: 4.7.2, Future > > > Register Template : > http://10.220.135.31:8096/client/api?command=registerTemplate&displaytext=urlapi&format=VHD&hypervisor=ABC&name=urlapi1&ostypeid=6c590b5c-fde9-11e4-b65a-a20b7b72c771&url=http://10.147.28.7/templates/rajani-thin-volume.vhd&zoneid=1e7bbab9-02cd-4067-99f9-3f8b115304df > getUploadParamsForTemplate : > http://10.81.29.49:8096/client/api?command=getUploadParamsForTemplate&type=template&response=json&name=nossvm&displayText=nossvmnossvm&zoneid=ca8adf51-539d-45eb-b205-792a58503d14&format=VHD&isextractable=false&passwordEnabled=false&isdynamicallyscalable=false&osTypeId=ce099056-ee53-11e4-a8ad-d242118f6f9b&hypervisor=XEN&requireshvm=false&apiKey=_cMgYFGzeE0QEMmqN5OWC5QpOm33UqGpVbAXUntbR_ESNoKX-N9TMNhCcl-lUbyYhT90k53gCkvSP0ZO3CWtxg&account=admin&domainid=cddff412-ee53-11e4-a8ad-d242118f6f9b > In the above API calls have given the hypervisor types as ABC and XEN respectively. No error is thrown and templates are sucessfully registerd and Uploaded . But they do not list in the Templates section as DB entry for the above shows HYpervisor as NONE . > Expected Result : > Hypervisor parameter should only accept values which the cloudstack currently supports and API should fail if we give any other values . Templates should not be uploaded for NONE type . -- This message was sent by Atlassian JIRA (v6.3.4#6332)