Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB8021956E for ; Thu, 28 Apr 2016 08:35:13 +0000 (UTC) Received: (qmail 2829 invoked by uid 500); 28 Apr 2016 08:35:13 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 2628 invoked by uid 500); 28 Apr 2016 08:35:13 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 2417 invoked by uid 500); 28 Apr 2016 08:35:13 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 2396 invoked by uid 99); 28 Apr 2016 08:35:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 08:35:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 12B032C1F6B for ; Thu, 28 Apr 2016 08:35:13 +0000 (UTC) Date: Thu, 28 Apr 2016 08:35:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8562) User Definable Roles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261758#comment-15261758 ] ASF GitHub Bot commented on CLOUDSTACK-8562: -------------------------------------------- Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215352448 @DaanHoogland @wido @mlsorensen @jburwell @agneya2001 @koushik-das @terbolous @resmo @K0zka review and LGTM please? @swill I think we've resolved all outstanding concerns, and if there are still any concern that should be shared, summary; - Existing users are not migrated automatically, they continue to use static-checker, @koushik-das raised concern if dynamic-checker is forced upon users -- it is not - Commands.properties file is only removed from codebase, after an upgrade this file won't be removed by the deb/rpm packages, @koushik-das raised concern on not removing it -- it is clarified that it's not for users with existing deployments - Valid points raised by @mlsorensen on why dynamic checker is the way forward and static-checker has several pain points for real world users - @koushik-das raised concerns about code quality and testing, my colleague @borisstoyanov and I have spent good time to test the feature against ldap, saml and native cloudstack authentication; along with upgrade and regression tests around the feature. The integration test runs with Travis as well, providing nearly 100% coverage > User Definable Roles > -------------------- > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Reporter: Paul Angus > Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)