Return-Path: 
 <issues-return-69466-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-issues-archive@www.apache.org
Delivered-To: apmail-cloudstack-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 01BFF19C04
	for <apmail-cloudstack-issues-archive@www.apache.org>;
 Thu, 14 Apr 2016 14:51:31 +0000 (UTC)
Received: (qmail 49200 invoked by uid 500); 14 Apr 2016 14:51:25 -0000
Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org
Received: (qmail 48988 invoked by uid 500); 14 Apr 2016 14:51:25 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 48874 invoked by uid 500); 14 Apr 2016 14:51:25 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 48866 invoked by uid 99); 14 Apr 2016 14:51:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2016 14:51:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 9045B2C1F5A
	for <cloudstack-issues@incubator.apache.org>;
 Thu, 14 Apr 2016 14:51:25 +0000 (UTC)
Date: Thu, 14 Apr 2016 14:51:25 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12837926.1434394107000.231064.1460645485588@Atlassian.JIRA>
In-Reply-To: <JIRA.12837926.1434394107000@Atlassian.JIRA>
References: <JIRA.12837926.1434394107000@Atlassian.JIRA>
 <JIRA.12837926.1434394107609@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241302#comment-15241302 ] 

ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------

Github user pdube commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r59730927
  
    --- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
    @@ -0,0 +1,43 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +
    +package org.apache.cloudstack.acl;
    +
    +import org.apache.cloudstack.framework.config.ConfigKey;
    +
    +import java.util.List;
    +
    +public interface RoleService {
    +
    +    ConfigKey<Boolean> EnableDynamicApiChecker = new ConfigKey<>("Hidden", Boolean.class, "dynamic.apichecker.enabled", "false",
    +            "If set to true, this enables the dynamic role-based api access checker and disables the default static role-based api access checker.",
    +            true);
    +
    +    boolean isEnabled();
    +    Role findRole(final Long id);
    +    Role createRole(final String name, final RoleType roleType, final String description);
    +    boolean updateRole(final Role role, final String name, final RoleType roleType, final String description);
    +    boolean deleteRole(final Role role);
    +
    +    RolePermission findRolePermission(final Long id);
    +    RolePermission createRolePermission(final Role role, final Rule rule, final RolePermission.Permission permission, final String description);
    +    boolean updateRolePermission(final RolePermission rolePermission, final Rule rule, final RolePermission.Permission permission, final String description);
    +    boolean deleteRolePermission(final RolePermission rolePermission);
    +
    +    List<Role> findAllRolesBy(final Long id, final String name, final RoleType roleType);
    --- End diff --
    
    I would have to agree with @DaanHoogland. Splitting into separate methods would be clearer and probably simplify the business logic per method as well (so it would be simpler to unit test).


> User Definable Roles
> --------------------
>
>                 Key: CLOUDSTACK-8562
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>            Reporter: Paul Angus
>            Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)