cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9354) Problem creating template from snapshot via Marvin
Date Thu, 21 Apr 2016 20:42:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252662#comment-15252662
] 

ASF subversion and git services commented on CLOUDSTACK-9354:
-------------------------------------------------------------

Commit 7cd2284bf554baac4d66783fdf1f59daee32b377 in cloudstack's branch refs/heads/master from
[~williamstevens@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7cd2284 ]

Merge pull request #1501 from mike-tutkowski/cs-9354

Fixing an issue in Marvin around creating a template from a snapshotThis fixes the following
ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9354

The problem was that Marvin was requiring you to pass in the "ispublic" parameter when creating
a template from a snapshot.

As the ticket notes, this issue was introduced by the following commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d

The solution I've provided is simply to check if the "ispublic" property is in the dictionary
before referencing it.

* pr/1501:
  CLOUDSTACK-9354 - Fixing an issue in Marvin around creating a template from a snapshot (if
“is public” is not provided, there was a problem)

Signed-off-by: Will Stevens <williamstevens@gmail.com>


> Problem creating template from snapshot via Marvin
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9354
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9354
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: marvin
>    Affects Versions: 4.9.0
>         Environment: N/A
>            Reporter: Mike Tutkowski
>            Assignee: Mike Tutkowski
>             Fix For: 4.9.0
>
>
> From an e-mail I sent to dev@ on April 14, 2016:
> Hi,
> I noticed an issue in Marvin the other day and I tracked it to this commit:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d
> The problem is that it assumes the "ispublic" parameter will be provided. If it is not,
then an exception is thrown.
> I think we want code more like this:
>         if "ispublic" in services:
>             cmd.ispublic = services["ispublic"]
> I don't think we would want to require the "ispublic" parameter in Marvin. It's not required
in our API:
> http://cloudstack.apache.org/api/apidocs-4.8/root_admin/createTemplate.html​
> Unless someone can think of a reason why this part of the code is the way it is now,
I plan to open a PR to fix this soon.
> Thanks,
> Mike



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message