cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Tutkowski (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CLOUDSTACK-9354) Problem creating template from snapshot via Marvin
Date Mon, 18 Apr 2016 17:55:25 GMT
Mike Tutkowski created CLOUDSTACK-9354:
------------------------------------------

             Summary: Problem creating template from snapshot via Marvin
                 Key: CLOUDSTACK-9354
                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9354
             Project: CloudStack
          Issue Type: Bug
      Security Level: Public (Anyone can view this level - this is the default.)
          Components: marvin
    Affects Versions: 4.9.0
         Environment: N/A
            Reporter: Mike Tutkowski
             Fix For: 4.9.0


>From an e-mail I sent to dev@ on April 14, 2016:

Hi,

I noticed an issue in Marvin the other day and I tracked it to this commit:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d

The problem is that it assumes the "ispublic" parameter will be provided. If it is not, then
an exception is thrown.

I think we want code more like this:

        if "ispublic" in services:
            cmd.ispublic = services["ispublic"]

I don't think we would want to require the "ispublic" parameter in Marvin. It's not required
in our API:

http://cloudstack.apache.org/api/apidocs-4.8/root_admin/createTemplate.html​

Unless someone can think of a reason why this part of the code is the way it is now, I plan
to open a PR to fix this soon.

Thanks,
Mike



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message