cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9351) Add ids parameter to resource listing API calls
Date Fri, 15 Apr 2016 18:15:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243345#comment-15243345
] 

ASF GitHub Bot commented on CLOUDSTACK-9351:
--------------------------------------------

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1497#discussion_r59917122
  
    --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
    @@ -1731,6 +1731,17 @@
             Long zoneId = cmd.getZoneId();
             Long podId = cmd.getPodId();
     
    +        List<Long> ids = null;
    --- End diff --
    
    Would you mind extracting lines 1734-1744 to a method? Then, you could write test cases
and even create some documentation for it.


> Add ids parameter to resource listing API calls
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-9351
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9351
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>             Fix For: 4.9.0
>
>
> h2. General behaviour
> A new parameter is added in each method, its type a list of IDs of the entity, it will
be mutually exclusive with id. (Similar to {{id}} and {{ids}} parameters in {{listVirtualMachines}}
method)
> h3. API Methods affected
> * +{{listTemplates}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVolumes}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listSnapshots}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVMSnapshots}}+: new parameter *{{vmsnapshotids}}*, mutually exclusive with {{vmsnapshotid}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message