cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9349) Unable to detach root volume when using Hypervisor Type KVM
Date Mon, 18 Apr 2016 13:20:25 GMT


ASF GitHub Bot commented on CLOUDSTACK-9349:

GitHub user dmabry opened a pull request:


    This PR addresses the KVM detach/attach ROOT disks from VMs (CLOUDSTACK-9349).  In short,
this allows the KVM Hypervisor, and I added the Simulator as a valid hypervisor for ease of
development and testing of marvin, to detach a root volume and the reattach a root volume
using the deviceid=0 flag to the attachVolume API.  I have also written a marvin integration
test that verifies this feature works for both KVM and the Simulator.
    Below is the marvin results files of the full marvin  All tests pass,
including the new root detach/attach, on our KVM lab running with the patches in this PR.

You can merge this pull request into a Git repository by running:

    $ git pull KVM_root_detach

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1500
commit 48ce76344040de2ab8014f76292abe0421d42f85
Author: Simon Weller <>
Date:   2016-03-24T19:55:34Z

    Merge pull request #4 from apache/4.7
    4.7 PR

commit d0a02640dfd4878da81a2e59588c4b5ff2a06401
Author: Simon Weller <>
Date:   2016-04-14T13:28:37Z

    Let hypervisor type KVM detach root volumes

commit 7807955433cea390bb7358e3bb90dbc9cc06bbea
Author: David Mabry <>
Date:   2016-04-15T12:30:07Z

    updated to include a test for detaching and reattaching a root volume
from a vm.  I also had to update to all attach_volume to have the parameter deviceid
to be passed as needed.

commit d7d55630daff4a5e17c9a374dc2e9bc478dff808
Author: David Mabry <>
Date:   2016-04-18T02:41:29Z

    Added Simulator as valid hypervisor for root detach


> Unable to detach root volume when using Hypervisor Type KVM
> -----------------------------------------------------------
>                 Key: CLOUDSTACK-9349
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Volumes
>    Affects Versions: 4.5.1, 4.6.2, 4.7.1, 4.8.0, 4.9.0
>         Environment: Centos 7
>            Reporter: Simon Weller
>            Priority: Minor
>             Fix For: 4.7.2
> Back in 4.5, support was added in CLOUDSTACK-6284 for detaching root volumes. The original
support was meant to work with Xen, VMware and KVM.
> After chatting with fuflo in the Cloudstack irc channel, it was pointed out that a constraint
was not correctly modified in to allow the detach to occur when
vm.getHypervisorType() == HypervisorType.KVM.
> This is a very useful feature, as it allows us to simulate a snapshot revert with Ceph
by using createVolume sourced from a snapshot, then detaching and reattaching the root volume
(new root volume needs to be attached as device=0).
> I'm going to propose a PR for this shortly

This message was sent by Atlassian JIRA

View raw message