cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9328) Fix vlan issues from test suite test_privategw_acl.py in BVT
Date Thu, 28 Apr 2016 18:05:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262639#comment-15262639
] 

ASF GitHub Bot commented on CLOUDSTACK-9328:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1455#issuecomment-215512619
  
    @sanju1010 though the code looks alright I don't like the integration test should be snooping
under the hood. I would rather see them behave as black-box tests. I am sure this kind of
validating happens elsewhere but still I would like some reason for it, can you explain?


> Fix vlan issues from test suite test_privategw_acl.py in BVT
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9328
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9328
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>            Reporter: Sanjeev N
>            Assignee: Sanjeev N
>
> Fix vlan issues from test suite test_privategw_acl.py in BVT
> Currently the tests reads the vlans from the physical network and takes the first vlan
from the list of vlans and uses it. However, this approach might not work when the tests run
in parallel. E.g. in CI we run test suits in parallel and the first vlan may not be available
and tests would fail if we try to use the vlan which is already in use.
> Made changes to the script so that it will get the free vlan list from the DB and uses
the first vlan from the available pool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message