cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9251) error while change instance offering to custom offering
Date Wed, 06 Apr 2016 21:46:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229194#comment-15229194
] 

ASF GitHub Bot commented on CLOUDSTACK-9251:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1363#discussion_r58787775
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java ---
    @@ -77,7 +80,18 @@ public Long getServiceOfferingId() {
         }
     
         public Map<String, String> getDetails() {
    -        return details;
    +        Map<String, String> customparameterMap = new HashMap<String, String>();
    +        if (details != null && details.size() != 0) {
    +            Collection parameterCollection = details.values();
    +            Iterator iter = parameterCollection.iterator();
    +            while (iter.hasNext()) {
    +                HashMap<String, String> value = (HashMap<String, String>)iter.next();
    --- End diff --
    
    the findbugs issue is here, a string is returned as a HashMap<String, String>. The
fact that this works is very ugly. It means that details is really a Map<String,Map<String,String>>.
If we want to both revert the issue and solve the findsbugs issue, the solution might be something
like writing a parser and parse the string iter.next() into a map. Not sure  though


> error while change instance offering to custom offering
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-9251
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9251
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.7.0, 4.7.1
>         Environment: ACS 4.7.1 -  https://dist.apache.org/repos/dist/dev/cloudstack/4.7.1/
>            Reporter: Tomasz Zieba
>
> Changing compute offering to custom offering end with:
> Step to reproduce:
> 1. Create and run new instance with offering eg. 1 core / 1GB
> 2. Create Custom Offering eg 2 core / 2 GB
> 3. Stop the instance
> 4. Try to change offering of the instance
> 5. Error: Invalid cpu cores value, specify a value between 1 and 2147483647



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message