cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9203) [API] extend updateVirtualMachine to support updating security groups
Date Mon, 11 Apr 2016 13:28:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235086#comment-15235086
] 

ASF GitHub Bot commented on CLOUDSTACK-9203:
--------------------------------------------

GitHub user DaanHoogland reopened a pull request:

    https://github.com/apache/cloudstack/pull/1297

    CLOUDSTACK-9203 Implement security group move on updateVM API call

      cherry-picked from a exoscale internal fix
    
    Conflicts:
    	api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
    	server/src/com/cloud/vm/UserVmManager.java
    	server/src/com/cloud/vm/UserVmManagerImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1297
    
----
commit c1040f0fb004c2aa4f39d8d8c195f9334a7b6014
Author: Loic Lambiel <lll@exoscale.ch>
Date:   2015-05-13T14:43:09Z

    CLOUDSTACK-9203 Implement security group move on updateVM API call
    
      cherry-picked from a exoscale internal fix
    
    Conflicts:
    	api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
    	server/src/com/cloud/vm/UserVmManager.java
    	server/src/com/cloud/vm/UserVmManagerImpl.java

commit acf33f24a1cbdacef1bd9ce6defd3def703f9433
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-12-30T12:13:38Z

    CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

commit bf7ab1f2d6ab1f568772b242a9b3018fb589f85e
Author: Loic Lambiel <lll@exoscale.ch>
Date:   2015-05-15T13:15:26Z

    CLOUDSTACK-9203 Prevent security group update while instance is running
    
          cherry-picked from a exoscale internal fix
    
     Conflicts:
    	api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

commit 0aff983cc81895a45295df6671b584d45975453e
Author: Wei Zhou <w.zhou@tech.leaseweb.com>
Date:   2016-01-12T09:56:07Z

    CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit 6ac415d8d4155c591acf1130f8bc445497993a33
Author: Daan Hoogland <daan.hoogland@gmail.com>
Date:   2016-01-12T10:10:30Z

    Merge pull request #3 from ustcweizhou/CLOUDSTACK-9203-multiple-shared-networks
    
    LGTM, exoscale probably only uses basic zone, so we need this extra.
    CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit be86551bc8cece5f619e9e54c04c9ec5f43fd6da
Author: Wei Zhou <w.zhou@tech.leaseweb.com>
Date:   2016-01-22T11:45:13Z

    CLOUDSTACK-9203: fix issue when update vm in isolated networks

commit 4e86f9a6c83d4c94a0f947e9070854da84f5bada
Author: Daan Hoogland <daan.hoogland@gmail.com>
Date:   2016-01-22T13:16:22Z

    Merge pull request #4 from ustcweizhou/CLOUDSTACK-9203-updatevm-isolated-network
    
    CLOUDSTACK-9203: fix issue when update vm in isolated networks

----


> [API] extend updateVirtualMachine to support updating security groups
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9203
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9203
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: René Moser
>            Assignee: Daan Hoogland
>            Priority: Minor
>             Fix For: Future
>
>
> There is currently no way to change security groups on exisitng VMs.
> {{updateVirtualMachine}} should be extended in a similar way as {{deployVirtualMachine}}
which should allow passing a list of IDs or names to update the security groups as passed:
> {{securitygroupids}} parameter
> comma separated list of security groups id that going to be applied to the virtual machine.
Should be passed only when vm is created from a zone with Basic Network support. Mutually
exclusive with securitygroupnames parameter, default: false
> {{securitygroupnames}} parameter
> comma separated list of security groups names that going to be applied to the virtual
machine. Should be passed only when vm is created from a zone with Basic Network support.
Mutually exclusive with securitygroupids parameter. default: false
> Exoscale did already some work in their branch which we are [allowed|https://twitter.com/resmo79/status/681428989018267648]
to use, see [https://github.com/exoscale/cloudstack/pull/6/]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message