cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8611) CS waits indefinitely for CheckS2SVpnConnectionsCommand to return
Date Mon, 04 Apr 2016 20:30:25 GMT


ASF GitHub Bot commented on CLOUDSTACK-8611:

Github user rafaelweingartner commented on a diff in the pull request:
    --- Diff: utils/src/test/java/com/cloud/utils/ssh/ ---
    @@ -0,0 +1,131 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.mockito.Mockito;
    +import org.mockito.runners.MockitoJUnitRunner;
    +import com.trilead.ssh2.ChannelCondition;
    +import com.trilead.ssh2.Session;
    +public class SshHelperTest {
    +    // throwSshExceptionIfConditionsTimeout tests
    +    @Test(expected = SshException.class)
    +    public void throwSshExceptionIfConditionsTimeoutTestTimeout() throws SshException
    +        SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.TIMEOUT);
    +    }
    +    @Test
    +    public void throwSshExceptionIfConditionsTimeoutTestClosed() throws SshException
    --- End diff --
    Ok, got it.
    thanks for the explanation.
    Maybe a change into those test methods name? When I read their name it feels that they
should throw an exception.

> CS waits indefinitely for CheckS2SVpnConnectionsCommand to return
> -----------------------------------------------------------------
>                 Key: CLOUDSTACK-8611
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Likitha Shetty
>            Assignee: Suresh Kumar Anaparti
>             Fix For: 4.6.1
> On one instance, CS began to execute CheckS2SVpnConnectionsCommand command on a router
but the command result was never returned to the MS. If a command never returns, then 'DirectAgent'
thread executing this command is blocked indefinitely and cannot pick up any other request.
> Now since this command is designed to execute in sequence on a host and is run regularly,
every execution of that command thereafter on that particular host ended up picking up a DirectAgent
thread and waiting for the previous execution to complete. And hence overtime, the host ended
up using and blocking all 'DirectAgent' threads indefinitely.

This message was sent by Atlassian JIRA

View raw message