cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
Date Wed, 20 Apr 2016 11:09:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249652#comment-15249652
] 

ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r60389152
  
    --- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java ---
    @@ -0,0 +1,109 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +
    +package org.apache.cloudstack.acl;
    +
    +import javax.persistence.Column;
    +import javax.persistence.Entity;
    +import javax.persistence.EnumType;
    +import javax.persistence.Enumerated;
    +import javax.persistence.GeneratedValue;
    +import javax.persistence.GenerationType;
    +import javax.persistence.Id;
    +import javax.persistence.Table;
    +import java.util.UUID;
    +
    +@Entity
    +@Table(name = "role_permissions")
    +public class RolePermissionVO implements RolePermission {
    --- End diff --
    
    I am not sure I understand how is back-compat going to be impacted. In the current model
I don't think there is any explicit deny. In the static checker the order is command.properties
override, command.properties and then the annotations. If the API is not found anywhere then
its a deny by default.
    About the wildcard permissions, the same can be referenced in multiple roles.
    About the 4th point, if it is for all roles then agree but what if it is for 90% of the
roles. Still there will be lot of duplication.


> User Definable Roles
> --------------------
>
>                 Key: CLOUDSTACK-8562
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>            Reporter: Paul Angus
>            Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message