cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9328) Fix vlan issues from test suite in BVT
Date Mon, 28 Mar 2016 10:58:25 GMT


ASF GitHub Bot commented on CLOUDSTACK-9328:

Github user shwetaag commented on a diff in the pull request:
    --- Diff: test/integration/smoke/ ---
    @@ -287,6 +298,16 @@ def performVPCTests(self, vpc_off, restart_with_cleanup = False):
             if not physical_networks:
       "No Physical Networks found!")
    +        qresultset = self.dbclient.execute(
    +            "select vnet from op_dc_vnet_alloc where physical_network_id=\
    +            (select id from physical_network where uuid='%s' ) and taken is NULL;" %
    +        )
    +        self.assertEqual(validateList(qresultset)[0],
    +                         PASS,
    +                         "Invalid sql query response"
    +        )
    +        #vlans = physical_networks[0].vlan.split('-')
    +        vlans = qresultset
             vlans = physical_networks[0].vlan.split('-')
    --- End diff --
    this split is not needed for getting correct vlan entry

> Fix vlan issues from test suite in BVT
> ------------------------------------------------------------
>                 Key: CLOUDSTACK-9328
>                 URL:
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>            Reporter: Sanjeev N
>            Assignee: Sanjeev N
> Fix vlan issues from test suite in BVT
> Currently the tests reads the vlans from the physical network and takes the first vlan
from the list of vlans and uses it. However, this approach might not work when the tests run
in parallel. E.g. in CI we run test suits in parallel and the first vlan may not be available
and tests would fail if we try to use the vlan which is already in use.
> Made changes to the script so that it will get the free vlan list from the DB and uses
the first vlan from the available pool.

This message was sent by Atlassian JIRA

View raw message