cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9322) Support for Internal LB fuctionality with Nuage VSP SDN Plugin including Marvin test coverage
Date Sun, 27 Mar 2016 22:41:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213645#comment-15213645
] 

ASF GitHub Bot commented on CLOUDSTACK-9322:
--------------------------------------------

Github user pedro-martins commented on the pull request:

    https://github.com/apache/cloudstack/pull/1452#issuecomment-202163598
  
    Hi @prashanthvarma.
    
    How about to use String.format() to create the strings in the loggers? The use of String
format will turn the strings in the logs more legible.
    
    Also, at line 344, could you use Collection.isEmpty(internalLbVms) instead of "internalLbVms
== null || internalLbVms.isEmpty()" ?
    
    Ty. 


> Support for Internal LB fuctionality with Nuage VSP SDN Plugin including Marvin test
coverage
> ---------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9322
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9322
>             Project: CloudStack
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation, Network Controller
>            Reporter: Mani Prashanth Varma Manthena
>             Fix For: 4.9.0
>
>         Attachments: results.txt, runinfo.txt
>
>
> PR: https://github.com/apache/cloudstack/pull/1452
> PR contents:
> 1) UI changes to support LB provider “InternalLbVm” during VPC offering creation.
> 2) Bug fix for CLOUDSTACK-9320.
> 3) Nuage VSP SDN Plugin related enhancements for VPC network functionality.
> 4) Marvin test coverage for Internal LB support on master with Nuage VSP SDN Plugin.
> 5) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 6) PEP8 & PyFlakes compliance with our Marvin test code.
> Test run:
> CloudStack$ nosetests --with-marvin --marvin-config=nuage_ant.cfg test/integration/plugins/nuagevsp/
-a tags=nuagevsp
> Test results:
> Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName:
test_nuage_UserDataPasswordReset | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Offering with different combinations of LB service providers ... ===
TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName:
test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks
| Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Internal LB functionality with different combinations of Internal
LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within
a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing
(wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status
: SUCCESS ===
> ok
> Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components
by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic
| Status : SUCCESS ===
> ok
> Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by
performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic
| Status : SUCCESS ===
> ok
> Test Basic VPC Network Functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network
| Status : SUCCESS ===
> ok
> Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName:
test_nuage_vsp | Status : SUCCESS ===
> ok
> Ran 11 tests in 12094.705s
> OK
> PEP8 & PyFlakes Compliance:
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/*.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/nuageTestCase.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_password_reset.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_network.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vsp.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message