cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9319) Timeout is not passed to virtual router operations consistently
Date Mon, 28 Mar 2016 00:14:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213682#comment-15213682
] 

ASF GitHub Bot commented on CLOUDSTACK-9319:
--------------------------------------------

Github user pedro-martins commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1451#discussion_r57537243
  
    --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
---
    @@ -180,7 +179,7 @@ private Answer applyConfig(NetworkElementCommand cmd, List<ConfigItem>
cfg) {
             boolean finalResult = false;
             for (ConfigItem configItem : cfg) {
                 long startTimestamp = System.currentTimeMillis();
    -            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem);
    +            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem,
VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT);
                 if (s_logger.isDebugEnabled()) {
                     long elapsed = System.currentTimeMillis() - startTimestamp;
                     s_logger.debug("Processing " + configItem + " took " + elapsed + "ms");
    --- End diff --
    
    Hi @insom .
    
    I know that this isn't your code but could you use String.format to create the string
that is used by logger?
    It turns the code more readable than using multiple strings concatenation.
    
    Ty.


> Timeout is not passed to virtual router operations consistently
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9319
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9319
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.8.0
>         Environment: KVM + Ceph cloud, Ubuntu hosts.
>            Reporter: Aaron Brady
>            Priority: Trivial
>
> The timeout parameter is not passed down to `applyConfigToVR` inside `VirtualRoutingResource`
in all cases.
> This timeout is worked out as 3 seconds per command or 120 seconds (whichever is larger),
but because it's not passed to the first invocation, the default (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT)
is used.
> In a recent upgrade of our Virtual Routers, the timeout was being hit and increasing
`router.aggregation.command.each.timeout` had no effect. I built a custom 4.8 agent with the
timeout increased to allow the upgrade to continue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message