cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9319) Timeout is not passed to virtual router operations consistently
Date Sun, 27 Mar 2016 21:26:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213626#comment-15213626
] 

ASF GitHub Bot commented on CLOUDSTACK-9319:
--------------------------------------------

Github user cristofolini commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1451#discussion_r57535012
  
    --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
---
    @@ -180,7 +179,7 @@ private Answer applyConfig(NetworkElementCommand cmd, List<ConfigItem>
cfg) {
             boolean finalResult = false;
             for (ConfigItem configItem : cfg) {
                 long startTimestamp = System.currentTimeMillis();
    -            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem);
    +            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem,
VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT);
    --- End diff --
    
    @insom Since you're now checking the timeout's validity when calling `applyConfigToVR`
shouldn't the last parameter passed through this call be `timeout` instead of `VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT`?


> Timeout is not passed to virtual router operations consistently
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9319
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9319
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.8.0
>         Environment: KVM + Ceph cloud, Ubuntu hosts.
>            Reporter: Aaron Brady
>            Priority: Trivial
>
> The timeout parameter is not passed down to `applyConfigToVR` inside `VirtualRoutingResource`
in all cases.
> This timeout is worked out as 3 seconds per command or 120 seconds (whichever is larger),
but because it's not passed to the first invocation, the default (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT)
is used.
> In a recent upgrade of our Virtual Routers, the timeout was being hit and increasing
`router.aggregation.command.each.timeout` had no effect. I built a custom 4.8 agent with the
timeout increased to allow the upgrade to continue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message