cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9319) Timeout is not passed to virtual router operations consistently
Date Sat, 26 Mar 2016 00:44:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212666#comment-15212666
] 

ASF GitHub Bot commented on CLOUDSTACK-9319:
--------------------------------------------

Github user insom commented on the pull request:

    https://github.com/apache/cloudstack/pull/1451#issuecomment-201620444
  
    @alexandrelimassantana Agreed, thanks for the review. I've added a commit removing the
prototype with the default. That has allowed me to remove that if altogether and place it
inside the `applyConfigToVR` method.
    
    @DaanHoogland Because the original commit is about the wrong signature for the method
being used I'm not quite sure how to add tests for it. I hope that this second commit will
help as it means the compiler can enforce things. Thanks for the review!
    
    (Also it's Friday and I don't have a Maven install on this laptop - should pass the CI
tests, if not, I may need to come back to it on Tuesday).


> Timeout is not passed to virtual router operations consistently
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9319
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9319
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.8.0
>         Environment: KVM + Ceph cloud, Ubuntu hosts.
>            Reporter: Aaron Brady
>            Priority: Trivial
>
> The timeout parameter is not passed down to `applyConfigToVR` inside `VirtualRoutingResource`
in all cases.
> This timeout is worked out as 3 seconds per command or 120 seconds (whichever is larger),
but because it's not passed to the first invocation, the default (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT)
is used.
> In a recent upgrade of our Virtual Routers, the timeout was being hit and increasing
`router.aggregation.command.each.timeout` had no effect. I built a custom 4.8 agent with the
timeout increased to allow the upgrade to continue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message