cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9317) Disabling static NAT on many IPs can leave wrong IPs on the router
Date Thu, 24 Mar 2016 13:09:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210188#comment-15210188
] 

ASF GitHub Bot commented on CLOUDSTACK-9317:
--------------------------------------------

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1450#discussion_r57313299
  
    --- Diff: server/test/com/cloud/network/IpAddressManagerTest.java ---
    @@ -0,0 +1,71 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +
    +package com.cloud.network;
    +
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.InjectMocks;
    +import org.mockito.Mock;
    +import org.mockito.MockitoAnnotations;
    +
    +import com.cloud.network.dao.IPAddressDao;
    +import com.cloud.network.dao.IPAddressVO;
    +import com.cloud.network.rules.StaticNat;
    +import com.cloud.network.rules.StaticNatImpl;
    +import com.cloud.utils.net.Ip;
    +
    +import static org.mockito.Mockito.when;
    +
    +import java.util.Collections;
    +import java.util.List;
    +
    +import static org.mockito.Mockito.anyLong;
    +import static org.mockito.Mockito.mock;
    +
    +public class IpAddressManagerTest {
    +
    +    @Mock
    +    IPAddressDao _ipAddrDao;
    +
    +    @InjectMocks
    +    IpAddressManagerImpl _ipManager;
    +
    +    @Before
    +    public void setup() {
    +        MockitoAnnotations.initMocks(this);
    +    }
    +
    +    @Test
    +    public void testGetStaticNatSourceIps() {
    +        String publicIpAddress = "192.168.1.3";
    +        IPAddressVO vo = mock(IPAddressVO.class);
    +        when(vo.getAddress()).thenReturn(new Ip(publicIpAddress));
    +        when(vo.getId()).thenReturn(1l);
    +
    +        when(_ipAddrDao.findById(anyLong())).thenReturn(vo);
    +        StaticNat snat = new StaticNatImpl(1, 1, 1, 1, publicIpAddress, false);
    +
    +        List<IPAddressVO> ips = _ipManager.getStaticNatSourceIps(Collections.singletonList(snat));
    +        Assert.assertNotNull(ips);
    +        Assert.assertEquals(1, ips.size());
    +
    --- End diff --
    
    I would also add a check here to confirm that the ipAddrDao was called only once.


> Disabling static NAT on many IPs can leave wrong IPs on the router
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9317
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9317
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server, Virtual Router
>    Affects Versions: 4.7.0, 4.7.1, 4.7.2
>            Reporter: Jeff Hair
>
> The current behavior of enabling or disabling static NAT will call the apply IP associations
method in the management server. The method is not thread-safe. If it's called from multiple
threads, each thread will load up the list of public IPs in different states (add or revoke)--correct
for the thread, but not correct overall. Depending on execution order on the virtual router,
the router can end up with public IPs assigned to it that are not supposed to be on it anymore.
When another account acquires the same IP, this of course leads to network problems.
> The problem has been in CS since at least 4.2, and likely affects all recently released
versions. Affected version is set to 4.7.x because that's what we verified against.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message