cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9315) Remove unused classes
Date Mon, 21 Mar 2016 13:20:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204163#comment-15204163
] 

ASF GitHub Bot commented on CLOUDSTACK-9315:
--------------------------------------------

Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015
  
    @DaanHoogland the lack of test in some classes indeed is a problem. However, these classes
that I removed are not being used.
    
    I used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse.  With this tool,
I discovered a lot of code without any reference (variables, methods and classes).
    
    This pull request had the goal of removing some of these classes. To ensure that I wasn't
missing anything I searched for any file that could reference some answer or API command.
As I haven't found any way of these classes being used, I removed them.
    
    Any of those API commands that I deleted are not using org.apache.cloudstack.api.APICommand
(with `@APICommand`). Therefore, those commands are not exposed in the ACS API.


> Remove unused classes
> ---------------------
>
>                 Key: CLOUDSTACK-9315
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9315
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.9.0
>            Reporter: Gabriel Beims Bräscher
>            Priority: Trivial
>
> Remove unused Classes (total of 12 classes and 799 lines to remove):
> - com.cloud.agent.api.CheckStateAnswer
> - com.cloud.agent.api.StartupVMMAgentCommand
> - com.cloud.agent.api.routing.UserDataCommand (remove from description at com.cloud.configuration.Config.ExecuteInSequenceNetworkElementCommands
enum)
> - com.cloud.agent.api.storage.UpgradeDiskCommand
> - com.cloud.agent.api.storage.CreatePrivateTemplateCommand
> - com.cloud.agent.api.storage.DestroyAnswer (Note: "FIXME: Should have an DestroyAnswer"
at com.cloud.storage.resource.StoragePoolResource)
> - com.cloud.agent.api.storage.UpgradeDiskAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityCommand
> - com.cloud.exception.UsageServerException
> - com.cloud.info.SecStorageVmLoadInfo
> - com.cloud.serializer.SerializerHelper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message