cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot
Date Thu, 17 Mar 2016 15:35:33 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199728#comment-15199728
] 

ASF GitHub Bot commented on CLOUDSTACK-9297:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197935023
  
    @mike-tutkowski thanks for the improvements on PR title and description. 
    I understand the point of throwing an exception and I really like that approach.
    
    About the suggested change on “canHandle” method, I still did not see the need to
use the enum. If you were using more than 2 values as its returns, it would be something I
would understand; but you only use two values that could be represented as a “true” or
“false”.
    
    Could you elaborate a little bit more?
    I also did not understand this sentence:
    “I see returning true as your revert was successful and returning false as it failed
(but it was OK for you to ask us to revert because canHandle properly told you that you could
do so)”
    
    



> delete snapshot without id is failing with Unable to determine the storage pool of the
snapshot
> -----------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9297
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.7.0, 4.8.0
>         Environment: Ubuntu 14.04.3 management + kvm
>            Reporter: Özhan Rüzgar Karaman
>            Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message