cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD
Date Wed, 23 Mar 2016 13:47:25 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208417#comment-15208417
] 

ASF GitHub Bot commented on CLOUDSTACK-8302:
--------------------------------------------

Github user andrijapanic commented on the pull request:

    https://github.com/apache/cloudstack/pull/1230#issuecomment-200350271
  
    I believe this is the reason Dmytro edit it, since it handles KVM stuff
    also...
    
    On 23 March 2016 at 14:40, Simon Weller <notifications@github.com> wrote:
    
    > @DaanHoogland <https://github.com/DaanHoogland>
    >
    > So I've been digging into this a bit. I could be very wrong here, but it
    > seems that XenserverSnapshotStrategy is a very inaccurate description of
    > what this class is actually doing. It seems to be very general and based on
    > some investigation being used for KVM as well. This might be an old
    > artifact of the original feature being Xen specific, until others
    > re-purposed it for other hypervisors.
    >
    > Mike @mike-tutkowski <https://github.com/mike-tutkowski> mentioned
    > something to this effect very recently in this PR: #1441
    > <https://github.com/apache/cloudstack/pull/1441>
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/1230#issuecomment-200347989>
    >
    
    
    
    -- 
    
    Andrija Panić



> Cleanup snapshot on KVM with RBD
> --------------------------------
>
>                 Key: CLOUDSTACK-8302
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM, Snapshot, Storage Controller
>    Affects Versions: 4.4.0, 4.4.1, 4.4.2
>         Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>            Reporter: Star Guo
>            Assignee: Wido den Hollander
>            Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When delete a snapshot
the UI show OK, but the snapshot of the volume in the RBD pool is still exist.
> And I find the code in com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
>     @Override
>     public Answer deleteSnapshot(DeleteCommand cmd) {
>         return new Answer(cmd);
>     }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
>     @Override
>     public Answer createTemplateFromSnapshot(CopyCommand cmd) {
>         return null;  //To change body of implemented methods use File | Settings | File
Templates.
>     }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but not do
that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message