Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAA8B1802D for ; Mon, 29 Feb 2016 22:34:19 +0000 (UTC) Received: (qmail 50310 invoked by uid 500); 29 Feb 2016 22:34:19 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 50173 invoked by uid 500); 29 Feb 2016 22:34:19 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 50028 invoked by uid 500); 29 Feb 2016 22:34:19 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 49935 invoked by uid 99); 29 Feb 2016 22:34:19 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Feb 2016 22:34:19 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D2FC72C1F88 for ; Mon, 29 Feb 2016 22:34:18 +0000 (UTC) Date: Mon, 29 Feb 2016 22:34:18 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9298) Improve performance of resource retrieval that have tags associated and target volumes, VMs and templates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9298?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D15172754#comment-15172754 ]=20 ASF GitHub Bot commented on CLOUDSTACK-9298: -------------------------------------------- Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190430298 =20 @nvazquez ,=20 Lines 191-195 and 261-265 are duplicated, could you extract it to a met= hod? And maybe even document it. =20 At the =E2=80=9CResourceTagJoinVO=E2=80=9D, why did you create that new= constructor? =20 Additionally, have you tested that view select? It looks ok, but I did = not check clause per clause. > Improve performance of resource retrieval that have tags associated and t= arget volumes, VMs and templates > -------------------------------------------------------------------------= -------------------------------- > > Key: CLOUDSTACK-9298 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-929= 8 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: API > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Fix For: 4.9.0 > > > h2. Description of the problem > When retrieving a large number of resources which have tags associated wi= th, retrieval methods took too long. Our goal is to improve performance of = this methods > h3. ListTemplatesCmd API method > It is proposed to include tags information into template_view to avoid qu= erying the database for each tag, managing that information in memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)