Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Mon, 8 Feb 2016 16:58:40 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12937070.1454687917000.329720.1454950720033@Atlassian.JIRA>
In-Reply-To: <JIRA.12937070.1454687917000@Atlassian.JIRA>
References: <JIRA.12937070.1454687917000@Atlassian.JIRA>
 <JIRA.12937070.1454687917164@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9280) System VM volumes cannot be
 deleted when there are no system VMs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137239#comment-15137239 ] 

ASF GitHub Bot commented on CLOUDSTACK-9280:
--------------------------------------------

GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1406

    CLOUDSTACK-9280: Allow system VM volumes to be expunged if no system VMs are remaining.

    This pull request is our proposed fix for https://issues.apache.org/jira/browse/CLOUDSTACK-9280. I added a new special SSVM endpoint that happily accepts any command given to it. This endpoint is used in only a very specific scenario:
    
    The volume's VM is in state destroyed or expunging, but the volume still lingers.
    The volume's VM is a system VM (SSVM or console proxy).
    There are no secondary storage machines existing in the volume's zone.
    This necessitated a small change to VolumeObject which allows it to find removed VMs (findByIdIncludingRemoved). The main part of the work is in the DefaultEndpointSelector.
    
    We would like some thorough review of this PR as well as what tests to create/run. I'm not sure if the scope of this fix will lead to unintentional behavior changes in other scenarios.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-volume-expunge-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1406
    
----
commit b5f10b0d9bbf1a6788e82ae86d02e1ba484f238e
Author: jeff <jeff@greenqloud.com>
Date:   2016-02-08T16:30:03Z

    CLOUDSTACK-9280: System VM volumes can be expunged if no SSVM exists.
    
    This commit adds a special SSVM endpoint which simply returns true for
    all operations sent to it, without actually doing anything. This
    allows for destroyed volumes of system VMs to be expunged when there
    are no hosts (and thus no system VMs) remaining to handle the volume
    destruction.

----


> System VM volumes cannot be deleted when there are no system VMs
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9280
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9280
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0, 4.7.0
>            Reporter: Jeff Hair
>
> Scenario: When deleting a zone, everything under it must be removed. This results in the system VMs being destroyed as there are no more hosts running.
> The storage cleanup thread properly detects that there are volumes to be deleted, but it cannot delete them because the endpoint selection fails with "No remote endpoint to send DeleteCommand, check if host or ssvm is down?"


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)