Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 24 Feb 2016 10:03:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12862996.1441877480000.131909.1456308198089@Atlassian.JIRA>
In-Reply-To: <JIRA.12862996.1441877480000@Atlassian.JIRA>
References: <JIRA.12862996.1441877480000@Atlassian.JIRA>
 <JIRA.12862996.1441877480417@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8829) Consecutive cold migration
 fails
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162760#comment-15162760 ] 

ASF GitHub Bot commented on CLOUDSTACK-8829:
--------------------------------------------

Github user maneesha-p commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/797#discussion_r53916405
  
    --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
    @@ -1776,19 +1773,26 @@ private void orchestrateStorageMigration(final String vmUuid, final StoragePool
                     // If VM was cold migrated between clusters belonging to two different VMware DCs,
                     // unregister the VM from the source host and cleanup the associated VM files.
                     if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
    +                    Long srcClusterId = null;
    +                    Long srcHostId = vm.getHostId() != null ? vm.getHostId() : vm.getLastHostId();
    +                    if (srcHostId != null) {
    +                        HostVO srcHost = _hostDao.findById(srcHostId);
    --- End diff --
    
    @alexandrelimassantana 'srcHost' variable is local to the if-block but 'srcClusterId' variable that is populated inside the if-block is outside the scope of it and as @GabrielBrascher mentioned its being used in line 1784.


> Consecutive cold migration fails
> --------------------------------
>
>                 Key: CLOUDSTACK-8829
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8829
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Maneesha
>            Assignee: Maneesha
>
> The following scenario is broken:
> 1.	Deploy VM and stop it
> 2.	Migrate stopped VM to a different primary storage pool
> 3.	Again migrate the same VM to another/same storage pool. Fails with NPE.
> java.lang.NullPointerException
>         at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStorageMigration(VirtualMachineManagerImpl.java:1745)
>         at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStorageMigration(VirtualMachineManagerImpl.java:4716)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:606)
>         at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
>         at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4723)
>         at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:103)


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)