cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9252) Support configurable NFS version for Secondary Storage mounts
Date Tue, 09 Feb 2016 11:14:18 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138797#comment-15138797
] 

ASF GitHub Bot commented on CLOUDSTACK-9252:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1361#issuecomment-181819761
  
    @nvazquez, luckily the Jenkins build finished with success now.
    
    @kishankavala, for now, I believe the simplest solution is the better. When more details
are necessary, we change the code to send a map or some other structure, I personally do not
like using maps to move data around, I prefer simple and descriptive POJOs.
    
    Additionally, the task to move getters and setters to an upper class is not easily achievable.
I thought about that a while, and after inspecting the command classes that would have to
be changed, I decided to mark that as a future work; of course, if you have an easy, nice
and neat solution, you are welcome to share. @nvazquez had around worked around a lot of problems
and had written a pretty nice, well documented and tested code.
    
    @nvazquez, after all emails and messages exchanged, I can give an LGTM to this PR. Great
job man ;)



> Support configurable NFS version for Secondary Storage mounts
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9252
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9252
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>            Reporter: Nicolas Vazquez
>
> After starting secondary storage VM, secondary storage tries to be mounted but fails
with error: {{Protocol family not supported}}
> It was found out that adding {{-o vers=X}} to mount command it would work, where {{X}}
is the desired NFS version to use. 
> If it is desired to mount a store with a specific NFS version, it has passed in {{image_store_details}}
table for a store with id {{Y}} as a property:
> ||store_id||||name||value||
> |Y|nfs.version|X|
> Where X stands for NFS version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message