cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8958) add dedicated ips to domain
Date Fri, 05 Feb 2016 14:32:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134257#comment-15134257
] 

ASF GitHub Bot commented on CLOUDSTACK-8958:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1357#discussion_r52021538
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {
             return _networkOfferingDao.search(sc, searchFilter);
         }
     
    +     @Override
    +     @DB
    +     public boolean releaseDomainSpecificVirtualRanges(final long domainId) {
    +        final List<DomainVlanMapVO> maps = _domainVlanMapDao.listDomainVlanMapsByDomain(domainId);
    +        if (maps != null && !maps.isEmpty()) {
    --- End diff --
    
    @ustcweizhou Thanks for your changes, the code is ok, just one more thing.
    Could you please change the condition (**maps != null && !maps.isEmpty()**) for
(**MapUtils.isEmpty(maps)**)?
    
    Thanks


> add dedicated ips to domain
> ---------------------------
>
>                 Key: CLOUDSTACK-8958
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> add dedicated ips to domain 
> ips are dedicated to Account for now, so other customers and projects in the same domain
will use the system ip. this is not what we need.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message