cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-6928) IOPS throttling setting isn't applied to a dinamically attached volume
Date Sat, 20 Feb 2016 20:06:18 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155741#comment-15155741
] 

ASF GitHub Bot commented on CLOUDSTACK-6928:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1410#discussion_r53556330
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
    @@ -1006,6 +1006,19 @@ protected synchronized String attachOrDetachDisk(final Connect
conn, final boole
                     } else if (attachingDisk.getFormat() == PhysicalDiskFormat.RAW) {
                         diskdef.defBlockBasedDisk(attachingDisk.getPath(), devId, DiskDef.DiskBus.VIRTIO);
                     }
    +
    +                if ((bytesReadRate != null) && (bytesReadRate > 0)) {
    +                    diskdef.setBytesReadRate(bytesReadRate);
    +                }
    +                if ((bytesWriteRate != null) && (bytesWriteRate > 0)) {
    +                    diskdef.setBytesWriteRate(bytesWriteRate);
    +                }
    +                if ((iopsReadRate != null) && (iopsReadRate > 0)) {
    +                    diskdef.setIopsReadRate(iopsReadRate);
    +                }
    +                if ((iopsWriteRate != null) && (iopsWriteRate > 0)) {
    --- End diff --
    
    @ustcweizhou Those conditions coud be done by a method, where the I/O source (bytesReadRate
, bytesWriteRate, iopsReadRate  or iopsWriteRate) is passed as parameter. For example:
    
    `public boolean isIORateNotNullAndBiggerThanZero(Long io) {`
    `retun (io != null) && (io > 0);`
    `}`
    
    This sugestion could allow a test case, also it makes the code more readable (in my opinion).
    
    Thanks.


> IOPS throttling setting isn't applied to a dinamically attached volume
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-6928
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6928
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: Future, 4.4.0
>         Environment: CloudStack 4.4-forward w/ KVM deployment
> Ubuntu Server 14.04
>            Reporter: Yoshikazu Nojima
>            Assignee: Wei Zhou
>            Priority: Critical
>              Labels: KVM
>
> IOPS throttling setting is NOT applied to a volume attached while VM is running.
> I confirmed the setting is applied to a volume attached while VM is stopped.
> attach volume agent log:
> 2014-06-17 19:07:22,356 DEBUG [cloud.agent.Agent] (agentRequest-Handler-3:null) Processing
command: org.apache.cloudstack.storage.command.AttachCommand
> 2014-06-17 19:07:22,401 DEBUG [kvm.storage.KVMStorageProcessor] (agentRequest-Handler-3:null)
Attaching device: <disk  device='disk' type='file'>
> <driver name='qemu' type='qcow2' cache='none' />
> <source file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/>
> <target dev='vdd' bus='virtio'/>
> </disk>
> start instance agent log:
> 2014-06-17 19:10:47,984 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-1:null)
starting i-2-3-VM: <domain type='kvm'>
> <name>i-2-3-VM</name>
> <uuid>8fad689b-d63d-4802-81d9-d11acf91b879</uuid>
> <description>CentOS 5.5 (64-bit)</description>
> <clock offset='utc'>
> </clock>
> <features>
> <pae/>
> <apic/>
> <acpi/>
> </features>
> <devices>
> <emulator>/usr/bin/kvm-spice</emulator>
> <interface type='bridge'>
> <source bridge='breth0-2453'/>
> <mac address='02:00:19:5e:00:01'/>
> <model type='virtio'/>
> <bandwidth>
> <inbound average='25600' peak='25600'/>
> <outbound average='25600' peak='25600'/>
> </bandwidth>
> </interface>
> <serial type='pty'>
> <target port='0'/>
> </serial>
> <graphics type='vnc' autoport='yes' listen='10.1.2.24' passwd='987a62e28e4358d8'/>
> <disk  device='disk' type='file'>
> <driver name='qemu' type='qcow2' cache='none' />
> <source file='/mnt/e70b1e09-b7e8-3f14-8779-cfb75b651119/b1967fe4-6100-4777-8804-26a349ef06ea'/>
> <target dev='vda' bus='virtio'/>
> </disk>
> <disk  device='disk' type='file'>
> <driver name='qemu' type='qcow2' cache='none' />
> <source file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/92920d85-1190-43ce-af03-5d2f6a6e1004'/>
> <target dev='vdb' bus='virtio'/>
> <iotune>
> <read_iops_sec>200</read_iops_sec>
> <write_iops_sec>200</write_iops_sec>
> </iotune>
> </disk>
> <disk  device='disk' type='file'>
> <driver name='qemu' type='qcow2' cache='none' />
> <source file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/>
> <target dev='vdd' bus='virtio'/>
> <iotune>
> <read_iops_sec>200</read_iops_sec>
> <write_iops_sec>200</write_iops_sec>
> </iotune>
> </disk>
> <disk  device='cdrom' type='file'>
> <driver name='qemu' type='raw' cache='none' />
> <source file=''/>
> <target dev='hdc' bus='ide'/>
> </disk>
> <console type='pty'>
> <target port='0'/>
> </console>
> <input type='tablet' bus='usb'/>
> </devices>
> <memory>1048576</memory>
> <devices>
> <memballoon model='none'/>
> </devices>
> <vcpu>1</vcpu>
> <os>
> <type  arch='x86_64' machine='pc'>hvm</type>
> <boot dev='cdrom'/>
> <boot dev='hd'/>
> </os>
> <cputune>
> <shares>1000</shares>
> </cputune>
> <cpu></cpu><on_reboot>restart</on_reboot>
> <on_poweroff>destroy</on_poweroff>
> <on_crash>destroy</on_crash>
> </domain>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message