Return-Path: 
 <issues-return-67566-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-issues-archive@www.apache.org
Delivered-To: apmail-cloudstack-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 63BB618E24
	for <apmail-cloudstack-issues-archive@www.apache.org>;
 Wed, 20 Jan 2016 12:48:40 +0000 (UTC)
Received: (qmail 36779 invoked by uid 500); 20 Jan 2016 12:48:40 -0000
Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org
Received: (qmail 36721 invoked by uid 500); 20 Jan 2016 12:48:40 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 36676 invoked by uid 500); 20 Jan 2016 12:48:40 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 36635 invoked by uid 99); 20 Jan 2016 12:48:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 12:48:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id E268F2C1F5D
	for <cloudstack-issues@incubator.apache.org>;
 Wed, 20 Jan 2016 12:48:39 +0000 (UTC)
Date: Wed, 20 Jan 2016 12:48:39 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12931472.1452866629000.157775.1453294119924@Atlassian.JIRA>
In-Reply-To: <JIRA.12931472.1452866629000@Atlassian.JIRA>
References: <JIRA.12931472.1452866629000@Atlassian.JIRA>
 <JIRA.12931472.1452866629790@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9239) lock account silently fails
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108466#comment-15108466 ] 

ASF subversion and git services commented on CLOUDSTACK-9239:
-------------------------------------------------------------

Commit d9ce59f11cb192c3a93d0f6f85190523f972259e in cloudstack's branch refs/heads/4.7 from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9ce59f ]

Merge pull request #1349 from DaanHoogland/CLOUDSTACK-9239

CLOUDSTACK-9239 throw exception on deprecated commandan API call to LockAccount fails silently with a 200 return and no contents. client are responsible to check and will find that no locking has actually occured. This way they may be lured to a sense of false security.
Throwing an exption makes the failure explicit.
cloudmonkey lock account name=<name> domainid=<id>
now errors out with an http result of 530

* pr/1349:
  CLOUDSTACK-9239 throw exception on deprecated command

Signed-off-by: Remi Bergsma <github@remi.nl>


> lock account silently fails
> ---------------------------
>
>                 Key: CLOUDSTACK-9239
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9239
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> lock account has an implementation consisting of a commented out contents of the execute method, hence it silently fails.
> We should throw at least a CloudRuntimeException or a NotImplemetedException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)