Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Sun, 10 Jan 2016 23:48:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12922317.1450260182000.69449.1452469719798@Atlassian.JIRA>
In-Reply-To: <JIRA.12922317.1450260182000@Atlassian.JIRA>
References: <JIRA.12922317.1450260182000@Atlassian.JIRA>
 <JIRA.12922317.1450260182519@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9180) Optimize concurrent VM
 deployment operation on same network
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091293#comment-15091293 ] 

ASF GitHub Bot commented on CLOUDSTACK-9180:
--------------------------------------------

Github user pedro-martins commented on the pull request:

    https://github.com/apache/cloudstack/pull/1251#issuecomment-170406819
  
    nice =)
    Can you create a java doc to explain your 'isRouterDeployed()'  (even the name explaining itself)? 
    If you can create a test case for only this method it will be more easy to verify if it stop working in future modifications =) 
    Thx.


> Optimize concurrent VM deployment operation on same network
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9180
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9180
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Koushik Das
>            Assignee: Koushik Das
>             Fix For: 4.7.0
>
>
> During VM deployment a check is performed to see if VR exists or not. If not it is created - first an entry is allocated in DB for VR and then it is deployed. The allocation logic is placed in a lock (based on network id) so that only one thread does the allocation. But the locking is implemented in a way such that all threads wait on that lock even when VR is already allocated. The correct approach would be to check if VR is allocated or not and acquire lock only when needed.
> This issue is more frequently seen when concurrently deploying VMs in basic zone as all threads try to acquire lock using the same network id. In advanced zone operations are spread across multiple networks and so less frequent.
> Refer to findOrDeployVirtualRouter() in RouterDeploymentDefinition.java.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)