Return-Path: 
 <issues-return-67031-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-issues-archive@www.apache.org
Delivered-To: apmail-cloudstack-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3775E17D0A
	for <apmail-cloudstack-issues-archive@www.apache.org>;
 Fri,  8 Jan 2016 12:18:40 +0000 (UTC)
Received: (qmail 11679 invoked by uid 500); 8 Jan 2016 12:18:40 -0000
Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org
Received: (qmail 11639 invoked by uid 500); 8 Jan 2016 12:18:40 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 11613 invoked by uid 500); 8 Jan 2016 12:18:39 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 11610 invoked by uid 99); 8 Jan 2016 12:18:39 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 12:18:39 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id CA0C72C14F4
	for <cloudstack-issues@incubator.apache.org>;
 Fri,  8 Jan 2016 12:18:39 +0000 (UTC)
Date: Fri, 8 Jan 2016 12:18:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12918699.1449205237000.57030.1452255519824@Atlassian.JIRA>
In-Reply-To: <JIRA.12918699.1449205237000@Atlassian.JIRA>
References: <JIRA.12918699.1449205237000@Atlassian.JIRA>
 <JIRA.12918699.1449205237882@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9104) VM naming convention in case
 vmware is used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15089128#comment-15089128 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1302#discussion_r49183061
 =20
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/re=
source/VmwareResource.java ---
    @@ -2032,11 +2032,20 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) =
{
    =20
         // Pair<internal CS name, vCenter display name>
         private Pair<String, String> composeVmNames(VirtualMachineTO vmSpe=
c) {
    -        String vmInternalCSName =3D vmSpec.getName();
    -        String vmNameOnVcenter =3D vmSpec.getName();
    -        if (_instanceNameFlag && vmSpec.getHostName() !=3D null) {
    -            vmNameOnVcenter =3D vmSpec.getHostName();
    +
    +        String vmInternalCSName =3D null;
    +        String vmNameOnVcenter  =3D null;
    +        if(vmSpec !=3D null)
    --- End diff --
   =20
    If today there is no way a null value is received in that method, I see=
 no reason to have that check in 2038.=20


> VM naming convention in case vmware is used
> -------------------------------------------
>
>                 Key: CLOUDSTACK-9104
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-910=
4
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>            Reporter: Priyank Parihar
>
> ISSUE
> =3D=3D=3D=3D=3D=3D
> VM naming convention in case vmware is used.
> Description
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> User with different account cannot create VMs with the same name, which w=
as possible earlier (I am not sure in which CCP version). That time naming =
convention used was like this =E2=80=9CI-<user-id>-<Display-Name>=E2=80=9D
> Currently if vm.instancename.flag is set to true the VM name will be exac=
tly as display name given.=20



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)