cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9252) Support configurable NFS version for Secondary Storage mounts
Date Tue, 26 Jan 2016 16:06:39 GMT


ASF GitHub Bot commented on CLOUDSTACK-9252:

Github user rafaelweingartner commented on the pull request:
    Ok, I understood that you want to maintain compatibility. 
    What I do not understand is that: If there is a problem with some NFS (they do not support
version discovery), why aren’t you always using the “mountService.getMountPoint” passing
the NFS version? Most of the times you just send a null, only at the SSVM code you are using
the version; wouldn’t this cause problems in some other piece of the code base such as the
one you found out?
    You already have the method “getNfsVersion” that will return a null if the version
is not configured; I do not see a good reason not to use it; this way we would have a more
concise code.
    Additionally, you have duplicated the code of “getNfsVersion” in two or three places,
I believe we should avoid those duplicated code.
    I would also add a Java doc to the “getNfsVersion”, stating what it does, what parameters
it looks for, what happens if it does not find the parameter and where (in the DB) those parameters
are stored.

> Support configurable NFS version for Secondary Storage mounts
> -------------------------------------------------------------
>                 Key: CLOUDSTACK-9252
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>            Reporter: Nicolas Vazquez
> After starting secondary storage VM, secondary storage tries to be mounted but fails
with error: {{Protocol family not supported}}
> It was found out that adding {{-o vers=X}} to mount command it would work, where {{X}}
is the desired NFS version to use. 
> If it is desired to mount a store with a specific NFS version, it has passed in {{image_store_details}}
table for a store with id {{Y}} as a property:
> ||store_id||||name||value||
> |Y|nfs.version|X|
> Where X stands for NFS version

This message was sent by Atlassian JIRA

View raw message