cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9245) As an User I want to be able to delete non-attached ACL lists that contain items
Date Fri, 22 Jan 2016 09:25:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112196#comment-15112196
] 

ASF GitHub Bot commented on CLOUDSTACK-9245:
--------------------------------------------

GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/1358

    CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains items

    This PR fixes the issue when trying to delete ACL lists which contain item. 
    
    It seemed it was not thought of when the ACS project started, when most user were relying
on the UI to execute those tasks. Nowadays, with automation all over the place and ACL lists
containing hundreds of items, it's very hard to have to delete them 1 by 1 either via the
UI. Writing scripts to do so might be a solution, but it would be much simpler to just delete
non-attached ACLs with all its items in one go.
    
    Also, destroying a VPC that contains ACL lists was "succeeding", but after that the ACL
list/items were messing up:
    
    ```
    list networkacls aclid=920d74b6-4d15-454f-b3a6-61e7a6ffd1a4
    Error 431: Unable to find VPC associated with acl
    {
      "cserrorcode": 4350,
      "errorcode": 431,
      "errortext": "Unable to find VPC associated with acl",
      "uuidList": []
    }
    ```
    
    So, it also cleans up ACLs when destroying VPCs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ekholabs/cloudstack fix/4.7-acl-delete-CLOUDSTACK-9245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1358
    
----
commit 7b106db4b20c457c367a0ab31ca0f984b2d9f752
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2016-01-21T14:51:30Z

    CLOUDSTACK-9245 - Formatting NetworkACLManagerImpl class

commit 84e89a58430897e63de773c0100481694986b3c1
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2016-01-21T14:51:55Z

    CLOUDSTACK-9245 - Formatting VpcManagerImpl class

commit 1571e01994a7d459aa1b123d90cc1418e0ab2037
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2016-01-21T14:52:53Z

    CLOUDSTACK-9245 - Formatting NetworkACLServiceImpl class

commit 81aeb4f4c7eeb6c9ffcebc82d82dc901d7f5c70c
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2016-01-21T15:16:11Z

    CLOUDSTACK-9245 - Deletes ACL items when destroying the VPC or deleting the ACL itself

----


> As an User I want to be able to delete non-attached ACL lists that contain items
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9245
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9245
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VPC
>    Affects Versions: 4.5.0, 4.6.0, 4.7.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.7.1
>
>
> Create a VPC, add a network, create an ACL, add items to the ACL, attached the ACL to
the network.
> Trying to delete it should fail, and it actually does. That's expected.
> Now detach the ACL from the network, delete the network, try to delete the ACL. It fails
because the ACL contains item.
> If we delete the VPC, the ACL is also deleted. We want to simply delete the ACL and its
items in one go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message