cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9239) lock account silently fails
Date Wed, 20 Jan 2016 13:19:40 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108513#comment-15108513
] 

ASF subversion and git services commented on CLOUDSTACK-9239:
-------------------------------------------------------------

Commit d9ce59f11cb192c3a93d0f6f85190523f972259e in cloudstack's branch refs/heads/master from
[~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9ce59f ]

Merge pull request #1349 from DaanHoogland/CLOUDSTACK-9239

CLOUDSTACK-9239 throw exception on deprecated commandan API call to LockAccount fails silently
with a 200 return and no contents. client are responsible to check and will find that no locking
has actually occured. This way they may be lured to a sense of false security.
Throwing an exption makes the failure explicit.
cloudmonkey lock account name=<name> domainid=<id>
now errors out with an http result of 530

* pr/1349:
  CLOUDSTACK-9239 throw exception on deprecated command

Signed-off-by: Remi Bergsma <github@remi.nl>


> lock account silently fails
> ---------------------------
>
>                 Key: CLOUDSTACK-9239
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9239
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> lock account has an implementation consisting of a commented out contents of the execute
method, hence it silently fails.
> We should throw at least a CloudRuntimeException or a NotImplemetedException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message